docs.sheetjs.com/docz/docs/09-miscellany/05-contributing.md

252 lines
6.4 KiB
Markdown
Raw Normal View History

2022-05-16 03:26:04 +00:00
---
2022-06-21 12:26:53 +00:00
sidebar_position: 5
2022-05-16 03:26:04 +00:00
---
# Contributing
Due to the precarious nature of the Open Specifications Promise, it is very
2022-10-19 10:05:59 +00:00
important to ensure code is cleanroom. [Contribution Notes](https://git.sheetjs.com/sheetjs/sheetjs/src/branch/master/CONTRIBUTING.md)
2022-05-16 03:26:04 +00:00
<details>
<summary><b>File organization</b> (click to show)</summary>
Folders:
| folder | contents |
|:-------------|:--------------------------------------------------------------|
| `bin` | server-side bin scripts (`xlsx.njs`) |
2022-09-05 10:00:35 +00:00
| `bits` | raw source files that make up the final script |
2022-05-16 03:26:04 +00:00
| `dist` | dist files for web browsers and nonstandard JS environments |
| `misc` | miscellaneous supporting scripts |
2022-09-05 10:00:35 +00:00
| `modules` | TypeScript source files that generate some of the bits |
| `packages` | Support libraries and tools |
2022-05-16 03:26:04 +00:00
| `test_files` | test files (pulled from the test files repository) |
2022-09-05 10:00:35 +00:00
| `tests` | browser tests (run `make ctest` to rebuild) |
| `types` | TypeScript definitions and tests |
2022-05-16 03:26:04 +00:00
</details>
After cloning the repo, running `make help` will display a list of commands.
2022-05-20 03:25:45 +00:00
## OS-Specific Setup
2022-05-16 03:26:04 +00:00
import Tabs from '@theme/Tabs';
import TabItem from '@theme/TabItem';
<Tabs>
2022-05-17 03:19:39 +00:00
<TabItem value="wsl" label="Windows WSL">
2022-08-23 03:20:02 +00:00
The MacOS/Linux workflow works in WSL. Initial setup is involved:
2022-05-16 03:26:04 +00:00
2022-05-17 03:19:39 +00:00
1) Install mercurial and subversion.
2022-05-16 03:26:04 +00:00
```bash
2022-05-17 03:19:39 +00:00
# Install support programs for the build and test commands
sudo add-apt-repository ppa:mercurial-ppa/releases
sudo apt-get update
sudo apt-get install mercurial subversion
sudo add-apt-repository --remove ppa:mercurial-ppa/releases
2022-05-16 03:26:04 +00:00
```
2022-05-17 03:19:39 +00:00
2) Install NodeJS
2022-05-16 03:26:04 +00:00
2022-05-17 03:19:39 +00:00
```bash
# Install bootstrap NodeJS and NPM within the WSL
curl -fsSL https://deb.nodesource.com/setup_16.x | sudo -E bash -
sudo apt-get install -y nodejs
2022-05-16 03:26:04 +00:00
2022-05-17 03:19:39 +00:00
# CLOSE AND REOPEN SHELL BEFORE CONTINUING
2022-05-16 03:26:04 +00:00
2022-05-17 03:19:39 +00:00
# Switch to `n`-managed NodeJS
sudo npm i -g n
sudo n 16
2022-05-16 03:26:04 +00:00
```
2022-11-07 10:41:00 +00:00
3) Build and install a version of Git with proper SSL support:
2022-05-16 03:26:04 +00:00
2022-05-17 03:19:39 +00:00
```bash
# Git does not support OpenSSL out of the box, must do this
curl -LO https://github.com/paul-nelson-baker/git-openssl-shellscript/raw/main/compile-git-with-openssl.sh
chmod +x compile-git-with-openssl.sh
./compile-git-with-openssl.sh
2022-05-16 03:26:04 +00:00
```
2022-08-23 03:20:02 +00:00
(instructions continued in the MacOS/Linux part)
2022-05-17 03:19:39 +00:00
</TabItem>
2022-08-23 03:20:02 +00:00
<TabItem value="osx" label="MacOS/Linux">
2022-05-17 03:19:39 +00:00
Initial setup:
0) Ensure mercurial, subversion, and NodeJS are installed. The WSL instructions
will have installed these dependencies, so WSL users can skip to step 1.
2022-11-12 09:16:51 +00:00
:::note
[The official NodeJS site](https://nodejs.org/en/download/) provides installers
for "LTS" and "Current" releases. The "LTS" version should be installed.
:::
Mercurial and Subversion:
<Tabs>
<TabItem value="l" label="Linux">
On Linux, install using the system package manager. Debian and Ubuntu use `apt`:
2022-05-17 03:19:39 +00:00
```bash
sudo apt-get install mercurial subversion
2022-05-16 03:26:04 +00:00
```
2022-11-12 09:16:51 +00:00
Other Linux distributions may use other package managers.
<details><summary><b>Steam Deck</b> (click to show)</summary>
Desktop Mode on the Steam Deck uses `pacman`. It also requires a few steps.
0) Switch to Desktop mode and open `Konsole`
1) Set a password for the user by running `passwd` and following instructions.
2) Disable read-only mode:
```bash
sudo steamos-readonly disable
```
(When prompted, enter the password assigned in step 1)
3) Configure keyring:
```bash
echo "keyserver hkps://keyserver.ubuntu.com" >> /etc/pacman.d/gnupg/gpg.conf
sudo pacman-key --init
sudo pacman-key --populate
sudo pacman-key --refresh-keys
```
4) Install dependencies:
```bash
yay -S base-devel mercurial subversion
```
</details>
</TabItem>
<TabItem value="m" label="MacOS">
On MacOS, install using Homebrew.
0) Open a terminal window and install Homebrew:
```bash
/bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh)"
```
1) Close the window, open a new terminal window, and disable analytics:
```bash
brew analytics off
```
To confirm analytics are disabled, run
```bash
brew analytics state
```
It should print `Analytics are disabled.`
2) Install Mercurial and Subversion:
2022-05-16 03:26:04 +00:00
```bash
2022-05-17 03:19:39 +00:00
brew install mercurial subversion
```
2022-11-12 09:16:51 +00:00
</TabItem>
</Tabs>
2022-05-16 03:26:04 +00:00
2022-05-17 03:19:39 +00:00
1) Install NodeJS modules for building the scripts
2022-05-16 03:26:04 +00:00
2022-05-17 03:19:39 +00:00
```bash
2022-05-16 03:26:04 +00:00
# Install dev dependencies
2022-05-17 03:19:39 +00:00
npm install
# Install global dependencies
2022-07-25 23:18:00 +00:00
sudo npm i -g mocha@2.5.3 voc @sheetjs/uglify-js
2022-05-17 03:19:39 +00:00
```
2022-11-12 09:16:51 +00:00
:::note Older Versions of Dependencies
Some of the dependencies are wildly out of date. While SheetJS aims to run in
older versions of NodeJS and browsers, some libraries have chosen to break
backwards compatibility. The specific versions are used because they are known
to work and known to produce consistent results.
:::
2022-05-17 03:19:39 +00:00
2) Initialize the test files:
```bash
make init
```
This step may take a while as it will be downloading a number of test files.
3) Run a short test, then run a build
```bash
# Short test
make test_misc
# Full Build
cd modules; make; cd ..
make dist
2022-05-20 03:25:45 +00:00
```
2022-06-21 12:26:53 +00:00
4) (For Deno testing) Install Deno:
2022-05-20 03:25:45 +00:00
```bash
curl -fsSL https://deno.land/install.sh | sh
2022-07-23 09:06:31 +00:00
```
5) (For Bun testing) Install Bun:
```bash
curl https://bun.sh/install | bash
2022-05-16 03:26:04 +00:00
```
</TabItem>
</Tabs>
2022-05-17 03:19:39 +00:00
## Development
The `xlsx.js` and `xlsx.mjs` files are constructed from the files in the `bits`
2022-08-24 00:51:18 +00:00
subfolder. The build script (run `make`) will concatenate the individual bits
to produce the scripts.
2022-05-17 03:19:39 +00:00
To produce the dist files, run `make dist`. The dist files are updated in each
version release and *should not be committed between versions*.
## Tests
The `test_misc` target runs the targeted feature tests. It should take 5-10
seconds to perform feature tests without testing against the full test battery.
New features should be accompanied with tests for the relevant file formats.
2022-05-16 03:26:04 +00:00
For tests involving the read side, an appropriate feature test would involve
reading an existing file and checking the resulting workbook object. If a
parameter is involved, files should be read with different values to verify that
the feature is working as expected.
For tests involving a new write feature which can already be parsed, appropriate
feature tests would involve writing a workbook with the feature and then opening
and verifying that the feature is preserved.
For tests involving a new write feature without an existing read ability, please
add a feature test to the kitchen sink `tests/write.js`.