Bad parenting / hierarchy construction when parent is after R / L sibling tree #15

New Issue

2021-12-28T21:29:41Z

rossj commented

2021-12-28 21:29:41 +00:00

(Migrated from github.com)

I've noticed some files that show an incorrect folder structure with this library. I believe the dad array is not filled correctly when a node comes before it's parent, and has R or L sibling nodes. I've attached a sample file that demonstrates the issue.

In the attached .cfb file, both some file 1 and some file 2 are sibling files under some folder, but js-cfb shows some file 2 as a root level file.

file.zip

I've noticed some files that show an incorrect folder structure with this library. I believe the `dad` array is not filled correctly when a node comes before it's parent, and has R or L sibling nodes. I've attached a sample file that demonstrates the issue. In the attached .cfb file, both `some file 1` and `some file 2` are sibling files under `some folder`, but js-cfb shows `some file 2` as a root level file. ![image](https://user-images.githubusercontent.com/735679/147608230-c53914bd-da3e-4645-837b-8a1a94ccb6c7.png) [file.zip](https://github.com/SheetJS/js-cfb/files/7786383/file.zip)

Sign in to join this conversation.