sheetjs/js-codepage
1
Fork 0
Code Issues 5 Pull Requests 1 Projects Releases Wiki Activity

Include sbcs.full.js in Node Package #14

New Issue
Closed
opened 2018-01-04 19:03:15 +00:00 by stephenegriffin · 3 comments
stephenegriffin commented 2018-01-04 19:03:15 +00:00 (Migrated from github.com)
Copy Link

I've found I can get by with sbcs.full.js and not need to load the 2mb cptable.js. However sbcs.full.js isn't available via npm (that I can find). Can we get it added to the package?

I've found I can get by with sbcs.full.js and not need to load the 2mb cptable.js. However sbcs.full.js isn't available via npm (that I can find). Can we get it added to the package?
stephenegriffin commented 2018-01-04 19:24:31 +00:00 (Migrated from github.com)
Copy Link

Confirmed: codepage@1.3.1 has this file under dist. c5339be089 slimmed up the package with the side effect of removing this file. Per documentation on https://www.npmjs.com/package/codepage I believe this was unintended.

Recommended fix: Add sbcs.full.js (and maybe sbcs.js) directly to package.json

Confirmed: codepage@1.3.1 has this file under dist. c5339be089338130529c2167587986af315219f9 slimmed up the package with the side effect of removing this file. Per documentation on https://www.npmjs.com/package/codepage I believe this was unintended. Recommended fix: Add sbcs.full.js (and maybe sbcs.js) directly to package.json
SheetJSDev commented 2018-01-04 19:58:32 +00:00 (Migrated from github.com)
Copy Link

@stephenegriffin we just pushed 1.11.1 that added sbcs.full.js to the node module. UNPKG has the file now! Since the code wasn't modified, we didn't rebuild the scripts with the new version number, but 1.12.0 will show the correct version number in the scripts.

@stephenegriffin we just pushed 1.11.1 that added sbcs.full.js to the node module. [UNPKG has the file now!](https://unpkg.com/codepage@1.11.1/dist/sbcs.full.js) Since the code wasn't modified, we didn't rebuild the scripts with the new version number, but 1.12.0 will show the correct version number in the scripts.
stephenegriffin commented 2018-01-04 21:49:45 +00:00 (Migrated from github.com)
Copy Link

Awesome - thanks for the unpkg tip too. Totally using that.

Awesome - thanks for the unpkg tip too. Totally using that.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
invalid

   
question

   
wontfix
No Label
bug
duplicate
enhancement
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sheetjs/js-codepage#14
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?