sheetjs
/
js-codepage
1
Fork 0
Code Issues 5 Pull Requests 1 Projects Releases Wiki Activity

Refactored CLI to be a separate package #24

Merged
garrettluu merged 2 commits from master into master 2020-06-19 22:30:35 +00:00
Conversation 1 Commits 2 Files Changed 7 +181 -109
garrettluu commented 2020-06-18 20:59:41 +00:00 (Migrated from github.com)
Copy Link

Moved the CLI to another package codepage-cli.

The source code for the CLI has been moved to packages/codepage-cli, and is called when the user executes the cli.js script.

Moved the CLI to another package [`codepage-cli`](https://www.npmjs.com/package/codepage-cli). The source code for the CLI has been moved to `packages/codepage-cli`, and is called when the user executes the `cli.js` script.
coveralls commented 2020-06-18 21:17:38 +00:00 (Migrated from github.com)
Copy Link

Coverage Status

Coverage remained the same at 97.494% when pulling 48cbd10b03 on garrettluu:master into 62fd61e2b7 on SheetJS:master.

[![Coverage Status](https://coveralls.io/builds/31571691/badge)](https://coveralls.io/builds/31571691) Coverage remained the same at 97.494% when pulling **48cbd10b03e74abd5e8fb5b24c278d2895bef151 on garrettluu:master** into **62fd61e2b7122819fb9a49dc83917d3daee881d9 on SheetJS:master**.
srijonsaha (Migrated from github.com) reviewed 2020-06-18 23:06:24 +00:00
packages/codepage-cli/package.json
srijonsaha (Migrated from github.com) commented 2020-06-18 23:06:24 +00:00
Copy Link

Might be worth removing the test script if there are no tests.

Might be worth removing the test script if there are no tests.
srijonsaha (Migrated from github.com) approved these changes 2020-06-18 23:06:38 +00:00
srijonsaha (Migrated from github.com) left a comment
Copy Link

Looks good!

Looks good!
SheetJSDev (Migrated from github.com) approved these changes 2020-06-18 23:12:51 +00:00
SheetJSDev (Migrated from github.com) left a comment
Copy Link

agree with @srijonsaha the "scripts" section should be removed

agree with @srijonsaha the "scripts" section should be removed
Sign in to join this conversation.
Reviewers
No reviewers
srijonsaha
SheetJSDev
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
invalid

   
question

   
wontfix
No Label
bug
duplicate
enhancement
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sheetjs/js-codepage#24
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?