sheetjs/sheetjs
24
Fork 24
Code Issues 167 Pull Requests 12 Wiki Activity

Fix cornercase of to_csv with skipHidden enabled

Browse Source 
When running `xlsx.stream.to_csv(sheet, { skipHidden: true })` on the only sheet in [this XLS-file from the Swedish Pension Authority](https://www.pensionsmyndigheten.se/content/dam/pensionsmyndigheten/blanketter---broschyrer---faktablad/statistik/premiepension/fonddata/nuvarande-och-tidigare-fonder/Lista%20alla%20fonder%20.xls) the stream never got to `on('end')`. I think it's because all the rows in the last `_read` call was set to hidden. This seems to have fixed it and makes sense to me but I'm not very familiar with node streams.
This commit is contained in:
Tor Nilsson Öhrn 2019-05-15 20:40:43 +02:00 committed by GitHub
parent 9a6d8a1d3d
commit cf8ae427c3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
bits/97_node.js
View File

@ -18,7 +18,6 @@ if(has_buf && typeof require != 'undefined') (function() {
var BOM = false;
stream._read = function() {
if(!BOM) { BOM = true; return stream.push("\uFEFF"); }
if(R > r.e.r) return stream.push(null);
while(R <= r.e.r) {
++R;
if ((rowinfo[R-1]||{}).hidden) continue;
@ -29,6 +28,7 @@ if(has_buf && typeof require != 'undefined') (function() {
break;
}
}
if(R > r.e.r) return stream.push(null);
};
return stream;
};