Sheet missing from Sheets object but showing up in SheetNames array #145

New Issue

2014-11-13T03:19:57Z

keemy commented

2014-11-13 03:19:57 +00:00

(Migrated from github.com)

I've attached a pretty minimal example of a failing document. Basically if you read the doc then you will see that the one Sheet is missing from the Sheets object. I believe it has something to do with the hyperlink (since if I remove it it will work) but I'm not entirely sure. (fails on both windows and linux if it makes a difference)

https://app.box.com/s/p4l4gms4085quuhgf796

I've attached a pretty minimal example of a failing document. Basically if you read the doc then you will see that the one Sheet is missing from the Sheets object. I believe it has something to do with the hyperlink (since if I remove it it will work) but I'm not entirely sure. (fails on both windows and linux if it makes a difference) https://app.box.com/s/p4l4gms4085quuhgf796

👍 1

SheetJSDev commented

2014-11-13 04:24:49 +00:00

(Migrated from github.com)

@keemy thanks for sharing! You did stumble upon a bug :)

Hyperlinks are usually stored in a special relationships file, which was not generated in this case. Even in the relevant test file the text is stored in the relationships. However, in the file you presented, the link is stored in-place. Fortunately the fix is straightforward.

Since we do not have a file like this in our test suite, I would like to add this file to the test suite. Is that acceptable?

@keemy thanks for sharing! You did stumble upon a bug :) Hyperlinks are usually stored in a special relationships file, which was not generated in this case. Even in the [relevant test file](https://github.com/SheetJS/test_files/blob/master/hyperlink_stress_test_2011.xlsx) the text is stored in the relationships. However, in the file you presented, the link is stored in-place. Fortunately the fix is straightforward. Since we do not have a file like this in our test suite, I would like to add this file to the test suite. Is that acceptable?

keemy commented

2014-11-13 05:38:02 +00:00

(Migrated from github.com)

Yup go for it I got rid of all the sensitive info before uploading it. Glad it's not too hard a fix (I spent a few hours trying to figure it out to not avail). Thanks.

SheetJSDev commented

2014-11-13 09:00:10 +00:00

(Migrated from github.com)

@keemy the recent change (h/t @harbhub ) should resolve the issue, it will appear in the next release

Sign in to join this conversation.