Incorrect handling of table:number-columns-repeated in ODS #177

Closed
opened 2015-02-20 11:25:55 +00:00 by ziacik · 5 comments
ziacik commented 2015-02-20 11:25:55 +00:00 (Migrated from github.com)

Hi. I think there may be incorrect handling of number-columns-repeated attribute in ODS files.

If I have a table where two adjacent cells have the same value, the second will not be present in Sheet object.

For example, having an ODS with A1 cell set to "A" and B1 cell set to "A" too,

console.log(require('xlsx').readFile('./Test.ods').Sheets.Sheet1);

outputs this:

{ A1: { t: 's', v: 'A', w: 'A' }, '!ref': 'A1' }

So B1 is missing there.

Version I tried this on is 0.7.12.

Hi. I think there may be incorrect handling of number-columns-repeated attribute in ODS files. If I have a table where two adjacent cells have the same value, the second will not be present in Sheet object. For example, having an ODS with `A1` cell set to "A" and `B1` cell set to "A" too, `console.log(require('xlsx').readFile('./Test.ods').Sheets.Sheet1);` outputs this: `{ A1: { t: 's', v: 'A', w: 'A' }, '!ref': 'A1' }` So B1 is missing there. Version I tried this on is 0.7.12.
SheetJSDev commented 2015-02-20 18:37:01 +00:00 (Migrated from github.com)

@ziacik do you have a sample file so I can take a look?

@ziacik do you have a sample file so I can take a look?
ziacik commented 2015-02-20 21:46:25 +00:00 (Migrated from github.com)

@SheetJSDev Sample file is at this link http://www.koliksoftware.net/Stuff/Test.ods

@SheetJSDev Sample file is at this link http://www.koliksoftware.net/Stuff/Test.ods
JavaScriptDude commented 2016-02-17 16:15:30 +00:00 (Migrated from github.com)

What is holding this back? This bug makes this toolset unusable for parsing ODS files. The patch works for me.

What is holding this back? This bug makes this toolset unusable for parsing ODS files. The patch works for me.
Dineshagrawal85 commented 2016-04-11 08:05:04 +00:00 (Migrated from github.com)

i'm facing same problem is there any solution for this?

i'm facing same problem is there any solution for this?
JavaScriptDude commented 2016-08-07 15:30:32 +00:00 (Migrated from github.com)

I had to fork this locally and apply ziacik's patch. Ugly but only way to get around this without involvement of owners.

I had to fork this locally and apply ziacik's patch. Ugly but only way to get around this without involvement of owners.
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sheetjs/sheetjs#177
No description provided.