Some files that won't convert #2

Closed
opened 2013-02-19 21:44:52 +00:00 by nathanathan · 3 comments
nathanathan commented 2013-02-19 21:44:52 +00:00 (Migrated from github.com)

xlsx files exported from google docs seem to cause errors. I was able to convert this workbook when it was in it's original excel format.

Also, I'm getting an apparently unrelated error when I try to convert this xlsx file generated by excel.

xlsx files exported from google docs seem to cause errors. I was able to convert [this workbook](https://www.dropbox.com/s/1g544j0n1uli6xk/gdocified.xlsx) when it was in it's original excel format. Also, I'm getting an apparently unrelated error when I try to convert [this xlsx file](https://www.dropbox.com/s/2l8q76x6x75e13t/interview.xlsx) generated by excel.
Niggler commented 2013-02-20 15:45:14 +00:00 (Migrated from github.com)

(both are clearly bugs and I'm currently testing a patch)

Quick summary of what happened:

In the first case (from gdocs), neither the core properties nor the worksheet dimensions were emitted by google docs (both of which I assumed were included in every xlsx workbook).

The fix is to have the parser deduce the dimensions if its not provided (and to use sheet names from the workbook manifest if the properties are not provided)

In the second case (from excel), there are empty cells in places like E1,F1,D2,E2,F2,... and according to the schema those cells shouldn't have been generated in the first place (in the XLS format there's a special type of cell for the cells that haven't been specified). In this case, I forced it to emit undefined (and updated sheet_to_row_object_array to ignore undefined elements)

(both are clearly bugs and I'm currently testing a patch) Quick summary of what happened: In the first case (from gdocs), neither the core properties nor the worksheet dimensions were emitted by google docs (both of which I assumed were included in every xlsx workbook). The fix is to have the parser deduce the dimensions if its not provided (and to use sheet names from the workbook manifest if the properties are not provided) In the second case (from excel), there are empty cells in places like E1,F1,D2,E2,F2,... and according to the schema those cells shouldn't have been generated in the first place (in the XLS format there's a special type of cell for the cells that haven't been specified). In this case, I forced it to emit undefined (and updated sheet_to_row_object_array to ignore undefined elements)
Niggler commented 2013-02-20 16:07:19 +00:00 (Migrated from github.com)

@nathanathan thanks a lot and keep the issues coming :) Also, can you tell me what version of excel you used for the second file?

@nathanathan thanks a lot and keep the issues coming :) Also, can you tell me what version of excel you used for the second file?
nathanathan commented 2013-02-20 18:27:45 +00:00 (Migrated from github.com)

Thanks!
The excel version I was using: 14.0.6129.5000 (32-bit)

Thanks! The excel version I was using: 14.0.6129.5000 (32-bit)
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sheetjs/sheetjs#2
No description provided.