Add option to force quotes around values in when exporting to csv #2009

Merged
enghong merged 1 commits from issue-1694 into master 2020-06-18 01:34:05 +00:00
enghong commented 2020-06-17 15:49:15 +00:00 (Migrated from github.com)

Fix #1694

Fix #1694
SheetJSDev commented 2020-06-17 16:39:20 +00:00 (Migrated from github.com)

Looks good, but is there a specific reason you need to quote every single field? Is there some corner case where SheetJS isn't quoting a value when it should?

Looks good, but is there a specific reason you need to quote every single field? Is there some corner case where SheetJS isn't quoting a value when it should?
enghong commented 2020-06-17 16:53:02 +00:00 (Migrated from github.com)

Not at all, SheetJS is quoting when it should.

I just have a client who explicitly need all values to be quoted, I'm not sure why either...
Then I found the #1694, so I decided to implement the option.

Not at all, SheetJS is quoting when it should. I just have a client who explicitly need all values to be quoted, I'm not sure why either... Then I found the #1694, so I decided to implement the option.
SheetJSDev (Migrated from github.com) approved these changes 2020-06-17 17:12:02 +00:00
garrettluu (Migrated from github.com) approved these changes 2020-06-18 01:33:31 +00:00
garrettluu (Migrated from github.com) left a comment

This looks like a good feature to add!

This looks like a good feature to add!
Sign in to join this conversation.
No description provided.