readSync doesn't check first 8 bytes for CFB #2034

New Issue

2020-06-29T23:11:02Z

barronwei commented

2020-06-29 23:11:02 +00:00

(Migrated from github.com)

readSync doesn't correctly check the first 8 bytes according to the spec in order to confirm CFB format in 768e1bdcf8/bits/87_read.js (L85)

I will provide a fix in a pull request.

[`readSync`](https://github.com/SheetJS/sheetjs/blob/768e1bdcf8d1820bdb69b62252c4b53ab22b10f8/bits/87_read.js#L67) doesn't correctly check the first 8 bytes according to the [spec](https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-cfb/05060311-bfce-4b12-874d-71fd4ce63aea) in order to confirm CFB format in https://github.com/SheetJS/sheetjs/blob/768e1bdcf8d1820bdb69b62252c4b53ab22b10f8/bits/87_read.js#L85 I will provide a fix in a pull request.

Sign in to join this conversation.