sheetjs
/
sheetjs
25
Fork 24
Code Issues 175 Pull Requests 12 Wiki Activity

Cross worksheet reference formulas #2046

Merged
mohammedsahl merged 1 commits from crossWorksheet-reference-formulas into master 2020-07-03 23:46:07 +00:00
Conversation 0 Commits 1 Files Changed 3 +22 -13
mohammedsahl commented 2020-07-03 21:40:35 +00:00 (Migrated from github.com)
Copy Link

This PR wraps worksheet references in formulas with single quotes if they contain characters that are not letter, numbers, underscores or within these Unicode blocks \u4E00-\u9FFF \u3040-\u30FF

This PR wraps worksheet references in formulas with single quotes if they contain characters that are not letter, numbers, underscores or within these Unicode blocks `\u4E00-\u9FFF` `\u3040-\u30FF`
wlawt (Migrated from github.com) approved these changes 2020-07-03 22:23:37 +00:00
wlawt (Migrated from github.com) left a comment
Copy Link

LGTM! I would just reference #2045 in the description of the PR 😊

LGTM! I would just reference #2045 in the description of the PR 😊
Sign in to join this conversation.
Reviewers
No reviewers
wlawt
Labels
Clear labels   
DBF

   
Dates

   
Defined Names

   
Features

   
Formula

   
HTML

   
Images

   
Infrastructure

   
Integration

   
International

   
ODS

   
Operations

   
Performance

   
PivotTables

   
Pro

   
Protection

   
Read Bug

   
SSF

   
SYLK

   
Style

   
Write Bug

   
good first issue
No Label
DBF
Dates
Defined Names
Features
Formula
HTML
Images
Infrastructure
Integration
International
ODS
Operations
Performance
PivotTables
Pro
Protection
Read Bug
SSF
SYLK
Style
Write Bug
good first issue
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sheetjs/sheetjs#2046
No description provided.
Delete Branch "crossWorksheet-reference-formulas"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?