Use of console.error instead of throw #27

New Issue

2013-05-18T12:09:39Z

Sebmaster commented

2013-05-18 12:09:39 +00:00

(Migrated from github.com)

There are a 2 instances, where console.error is used instead of throw. I just noticed in the tests for the file with the encoded filename xlsx.js#L643 will be executed.

How severe is the error? If it's not severe: IE 6 (prob. higher too) doesn't support console(.error) AFAIK so that would throw an exception and be unuseable.
If it's severe, the user should know about it. I'd suggest euther return it in the result, or with a throw.

There are a 2 instances, where console.error is used instead of throw. I just noticed in the tests for the file with the encoded filename [xlsx.js#L643](https://github.com/Sebmaster/js-xlsx/blob/master/xlsx.js#L634) will be executed. How severe is the error? If it's not severe: IE 6 (prob. higher too) doesn't support console(.error) AFAIK so that would throw an exception and be unuseable. If it's severe, the user should know about it. I'd suggest euther return it in the result, or with a throw.

Niggler commented

2013-05-18 12:18:09 +00:00

(Migrated from github.com)

Actually, both of them should be removed.

Sign in to join this conversation.