sheet_to_html does not handle blank sheets gracefully #2835

New Issue

codybreene · 2022-12-06T18:55:49Z

codybreene commented

2022-12-06 18:55:49 +00:00

First-time contributor

Currently, sheet_to_html fails when it attempts to parse a blank sheet because the decode_range helper function does not find the !ref key within the ws object (because it is empty).

Because there is not a book_to_html function, I'm using the sheet_to_html function to parse multiple sheets in a workbook, but some may be empty. Can we update the sheet_to_html function to do a null check on the sheet and return early?

Currently, `sheet_to_html` fails when it attempts to parse a blank sheet because the `decode_range` helper function does not find the `!ref` key within the `ws` object (because it is empty). Because there is not a `book_to_html` function, I'm using the `sheet_to_html` function to parse multiple sheets in a workbook, but some may be empty. Can we update the `sheet_to_html` function to do a null check on the sheet and return early?

sheetjs commented

2022-12-06 19:27:22 +00:00

Sure, and other methods should also check null object or missing worksheet range.

In the case of sheet_to_html, is it preferable to throw an error or generate an empty table?

Sure, and other methods should also check null object or missing worksheet range. In the case of `sheet_to_html`, is it preferable to throw an error or generate an empty table?

codybreene commented

2022-12-06 19:30:45 +00:00

First-time contributor

Thanks! I think generating an empty table makes sense.

Sign in to join this conversation.