Pull Requests Fail CI/CD Tests #2894

New Issue

abhiram11 · 2023-02-26T02:09:11Z

abhiram11 commented

2023-02-26 02:09:11 +00:00

Hi All,

I found sheetjs to be a fantastic library and product and thought of doing some open source contributions to it. Thus, I landed on (good-first-)issue #2752, read the conversation, and thought that since the issue is still open I could contribute to it.

Therefore, I added a PR #2815 on the Github Repo of sheetjs, but found that a few of the test cases were failing, but I thought that the chances of my code snippet being the reason of test fails is low.

So I opened another PR #2816 where I just changed a type of README.md and this time again, lots of test cases failed.

I would like to know if there is something missing from my end, or should I change the sheetjs default branch from github to master or something else, or to try a completely different approach?

P.S.: I am a new open source contributor looking for full time roles.

Hi All, I found sheetjs to be a fantastic library and product and thought of doing some open source contributions to it. Thus, I landed on (good-first-)issue #2752, read the conversation, and thought that since the issue is still open I could contribute to it. Therefore, I added a PR #2815 on the Github Repo of sheetjs, but found that a few of the test cases were failing, but I thought that the chances of my code snippet being the reason of test fails is low. So I opened another PR #2816 where I just changed a type of `README.md` and this time again, lots of test cases failed. I would like to know if there is something missing from my end, or should I change the `sheetjs` default branch from `github` to `master` or something else, or to try a completely different approach? P.S.: I am a new open source contributor looking for full time roles.

sheetjs commented

2023-02-26 02:22:02 +00:00

We haven't automated the test suite on git.sheetjs.com yet. Locally we run the following tests before release:

## Full build
make && make dist
# (check `git status`)
make clean
make && make dist
# (check `git status` to ensure the artifacts are the same)

## Node
# loop every major version
for n in 0.8 0.10 0.12 4 6 8 10 12 14 16 18; do
  # make sure you `sudo npm install -g n` once
  sudo n $n
  WTF=1 make test
done

## Deno
WTF=1 make test-deno
WTF=1 make test-denocp

## Browser
make ctest
make ctestserv
# (open browser and access test page)
# (run tests on sauce labs)

We'll take a closer look at the issue and the related PRs. Note that the legacy repo on GitHub is behind this repo.

PS: if you want to chat about open source in general, feel free to reach out on our Discord (https://discord.gg/sheetjs)

We haven't automated the test suite on git.sheetjs.com yet. Locally we run the following tests before release: ```bash ## Full build make && make dist # (check `git status`) make clean make && make dist # (check `git status` to ensure the artifacts are the same) ## Node # loop every major version for n in 0.8 0.10 0.12 4 6 8 10 12 14 16 18; do # make sure you `sudo npm install -g n` once sudo n $n WTF=1 make test done ## Deno WTF=1 make test-deno WTF=1 make test-denocp ## Browser make ctest make ctestserv # (open browser and access test page) # (run tests on sauce labs) ``` We'll take a closer look at the issue and the related PRs. Note that the legacy repo on GitHub is behind this repo. PS: if you want to chat about open source in general, feel free to reach out on our Discord (https://discord.gg/sheetjs)

❤️ 1

sheetjs closed this issue

2023-02-26 02:22:02 +00:00

abhiram11 commented

2023-02-26 02:37:43 +00:00

Thanks for the info! Really appreciate it.

I had one more doubt, my PR pushes at git.sheetjs.com require some username and password for push, which I don't think match with my github ones. That's why I am still pushing them on legacy repo on Github right now.

Please let me know if the credentials for pushing to git.sheetjs.com are different.

Thanks in Advance!

Thanks for the info! Really appreciate it. I had one more doubt, my PR pushes at git.sheetjs.com require some username and password for push, which I don't think match with my github ones. That's why I am still pushing them on legacy repo on Github right now. Please let me know if the credentials for pushing to git.sheetjs.com are different. Thanks in Advance!

Sign in to join this conversation.