sheet_to_json: rawNumber applied only when raw: true #2978

New Issue

JulitorK · 2023-08-27T05:22:22Z

JulitorK commented

2023-08-27 05:22:22 +00:00

I wanted to ask if this is expected behaviour:
485a4f30f1/bits/90_utils.js (L42)

row[hdr[C]] = raw && (val.t !== "n" || (val.t === "n" && o.rawNumbers !== false)) ? v : format_cell(val,v,o);

For now there is no way to apply rawNumber, if my parsing option is raw:false.

In the end result I would like to have all field types formatted except for numbers (because of e-notation), hence I want raw:false and assumed rawNumbers provide that exclusion.

I also noticed that previous commit to that line allowed it, so maybe there's some edge case I'm not seeing? Here's the previous version:
row[hdr[C]] = raw || (o.rawNumbers && val.t == "n") ? v : format_cell(val,v,o);

I wanted to ask if this is expected behaviour: https://git.sheetjs.com/sheetjs/sheetjs/src/commit/485a4f30f17ee6e2d79680133251f0dbfff74c6d/bits/90_utils.js#L42 `row[hdr[C]] = raw && (val.t !== "n" || (val.t === "n" && o.rawNumbers !== false)) ? v : format_cell(val,v,o);` For now there is no way to apply `rawNumber`, if my parsing option is `raw:false`. In the end result I would like to have all field types formatted except for numbers (because of e-notation), hence I want `raw:false` and assumed `rawNumbers` provide that exclusion. I also noticed that previous commit to that line allowed it, so maybe there's some edge case I'm not seeing? Here's the previous version: `row[hdr[C]] = raw || (o.rawNumbers && val.t == "n") ? v : format_cell(val,v,o);`

JulitorK referenced a pull request that will close this issue

2023-08-29 13:27:34 +00:00

`sheet_to_json`: allow `rawNumber` override `raw` option #2979

JulitorK commented

2023-08-29 13:31:15 +00:00

Opened #2979 to solve this