Converting sheets to arrays of objects doesn't work #3

New Issue

2013-02-25T21:13:21Z

paprikka commented

2013-02-25 21:13:21 +00:00

(Migrated from github.com)

in xlsx.js:335 there's a small error:

function sheet_to_row_object_array(sheet){
    var val, rowObject, range, columnHeaders, emptyRow, C;
    var outSheet = [];
    if (sheet["!ref"]) {
        range = XLSX.utils.decode_range(sheet["!ref"]);
                // XLSX.utils is undefined
                // it should be just utils.decode_range, I suppose

XLSX object is not necessary here (it's in method scope anyway).
(I wanted to send you a pull request but my laptop's battery is empty and I'm writing from an iPad).

in `xlsx.js:335` there's a small error: ``` function sheet_to_row_object_array(sheet){ var val, rowObject, range, columnHeaders, emptyRow, C; var outSheet = []; if (sheet["!ref"]) { range = XLSX.utils.decode_range(sheet["!ref"]); // XLSX.utils is undefined // it should be just utils.decode_range, I suppose ``` _XLSX object is not necessary here_ (it's in method scope anyway). (I wanted to send you a pull request but my laptop's battery is empty and I'm writing from an iPad).

Niggler commented

2013-02-25 22:43:45 +00:00

(Migrated from github.com)

"I wanted to send you a pull request but my laptop's battery is empty and I'm writing from an iPad"

I'll wait for you to send a pull request :) Note that the correction should be

    range = decode_range(sheet["!ref"]);

"Converting sheets to arrays of objects doesn't work"

I just tested it with a few files in chrome 24.0.1312.57 and safari 6.0.2 and there was no issue. Can you tell me what browser/os you used and what error you saw?

"I wanted to send you a pull request but my laptop's battery is empty and I'm writing from an iPad" I'll wait for you to send a pull request :) Note that the correction should be ``` range = decode_range(sheet["!ref"]); ``` "Converting sheets to arrays of objects doesn't work" I just tested it with a few files in chrome 24.0.1312.57 and safari 6.0.2 and there was no issue. Can you tell me what browser/os you used and what error you saw?

paprikka commented

2013-02-26 00:12:00 +00:00

(Migrated from github.com)

Uhm, sorry, I forgot to mention a quite important detail: I was using
node.js:).
Good work, by the way!

Rafał Pastuszak

Dnia 25 lut 2013 o godz. 23:43 Niggler notifications@github.com
napisał(a):

"I wanted to send you a pull request but my laptop's battery is empty and
I'm writing from an iPad"

I'll wait for you to send a pull request :) Note that the correction should
be

range = decode_range(sheet["!ref"]);

"Converting sheets to arrays of objects doesn't work"

I just tested it with a few files in chrome 24.0.1312.57 and safari 6.0.2
and there was no issue. Can you tell me what browser/os you used and what
error you saw?

—
Reply to this email directly or view it on
GitHubhttps://github.com/Niggler/js-xlsx/issues/3#issuecomment-14080992.

Uhm, sorry, I forgot to mention a quite important detail: I was using node.js:). Good work, by the way! ## Rafał Pastuszak Dnia 25 lut 2013 o godz. 23:43 Niggler notifications@github.com napisał(a): "I wanted to send you a pull request but my laptop's battery is empty and I'm writing from an iPad" I'll wait for you to send a pull request :) Note that the correction should be ``` range = decode_range(sheet["!ref"]); ``` "Converting sheets to arrays of objects doesn't work" I just tested it with a few files in chrome 24.0.1312.57 and safari 6.0.2 and there was no issue. Can you tell me what browser/os you used and what error you saw? — Reply to this email directly or view it on GitHubhttps://github.com/Niggler/js-xlsx/issues/3#issuecomment-14080992.

Niggler commented

2013-02-26 01:21:31 +00:00

(Migrated from github.com)

Pushed to NPM version 0.0.7 Thanks for checking this!

Sign in to join this conversation.