Infinite loop in XLSX.stream.to_json due to hidden row in Excel sheet #3176

New Issue

deepak-negi-web · 2024-08-14T11:57:15Z

deepak-negi-web commented

2024-08-14 11:57:15 +00:00

97_node.js

stream._read = function() {
		while(R <= r.e.r) {
			if ((rowinfo[R-1]||{}).hidden) continue;
			var row = make_json_row(sheet, r, R, cols, header, hdr, dense, o);
			++R;
			if((row.isempty === false) || (header === 1 ? o.blankrows !== false : !!o.blankrows)) {
				stream.push(row.row);
				return;
			}
		}
		return stream.push(null);
	};

Hi @SheetJSDev !

This line if ((rowinfo[R-1]||{}).hidden) continue; checks if the current row R is hidden in the spreadsheet. If the row is hidden, the loop uses the continue statement to skip processing the current row and move to the next iteration of the loop but without incrementing R. This leads to an infinite loop and XLSX.stream.to_json doesn't ends.

Also (rowinfo[R-1] || {}).hidden accesses the current row information assuming the current row number R in a one-based index but on debugging i found out the current Row R is a zero-based index.
So even using if ((rowinfo[R-1]||{}).hidden) { ++R; continue; }; will push wrong data where the hidden row is included in the stream and the next non-hidden row is skipped.

I'll be submitting a pull request to fix this issue that I have found.
Please verify and merge the changes as soon as possible as I am using this library in production in my system.

### 97_node.js ``` stream._read = function() { while(R <= r.e.r) { if ((rowinfo[R-1]||{}).hidden) continue; var row = make_json_row(sheet, r, R, cols, header, hdr, dense, o); ++R; if((row.isempty === false) || (header === 1 ? o.blankrows !== false : !!o.blankrows)) { stream.push(row.row); return; } } return stream.push(null); }; ``` **Hi @SheetJSDev !** This line `if ((rowinfo[R-1]||{}).hidden) continue;` checks if the current row `R` is hidden in the spreadsheet. If the row is hidden, the loop uses the continue statement to skip processing the current row and move to the next iteration of the loop but without incrementing R. This leads to an infinite loop and XLSX.stream.to_json doesn't ends. Also `(rowinfo[R-1] || {}).hidden` accesses the current row information assuming the current row number `R` in a one-based index but on debugging i found out the current Row `R` is a zero-based index. So even using ```if ((rowinfo[R-1]||{}).hidden) { ++R; continue; };``` will push wrong data where the hidden row is included in the stream and the next non-hidden row is skipped. I'll be submitting a pull request to fix this issue that I have found. Please verify and merge the changes as soon as possible as I am using this library in production in my system.

deepak-negi-web referenced a pull request that will close this issue

2024-08-14 12:34:10 +00:00

fix: infinite loop due to hidden row in XLSX.stream.to_json #3178

sheetjs closed this issue

2024-08-21 05:34:35 +00:00

sheetjs referenced this issue from a commit

2024-08-21 05:34:36 +00:00

fix: infinite loop due to hidden row in XLSX.stream.to_json (#3178)

Sign in to join this conversation.