Contributing.md is slightly outdated #3233

New Issue

Akxe · 2024-10-04T09:03:08Z

Akxe commented

2024-10-04 09:03:08 +00:00

I was trying to contribute and be a good guy, so I read the CONTRIBUTING.md file. I found that it does reference GitHub inability to attach files even though you are self-hosting a different Git environment that does not share this limitation.

Since github does not support attachments
Not true, see proof bellow!

I was trying to contribute and be a good guy, so I read the `CONTRIBUTING.md` file. I found that it does reference GitHub inability to attach files even though you are self-hosting a different Git environment that does not share this limitation. > Since github does not support attachments Not true, see proof bellow!

proof.jpg

43 KiB

sheetjs commented

2024-10-04 13:14:25 +00:00

That comment was written in 2015 (more than 9 years ago!)

IIRC that comment was referring to email replies. You can reply to the email you receive in the issue thread and GitHub will automatically create a comment, but it won't pull attachments.

The comment should be clarified and updated to reflect the new distribution point. The email address should also be updated to oss@sheetjs.com

That comment was written in 2015 (more than 9 years ago!) IIRC that comment was referring to email replies. You can reply to the email you receive in the issue thread and GitHub will automatically create a comment, but it won't pull attachments. The comment should be clarified and updated to reflect the new distribution point. The email address should also be updated to `oss@sheetjs.com`

sheetjs referenced this issue from a commit

2024-10-21 13:43:50 +00:00

update CONTRIBUTING.md (fixes #3233 h/t @Akxe)

sheetjs closed this issue

2024-10-21 13:43:50 +00:00

sheetjs commented

2024-10-21 13:48:24 +00:00

The contributing guide has been refreshed.

In general, issues are the best contributions. If you encounter any problems in the future, please raise an issue first before contributing code. Sometimes there are special considerations

The contributing guide has been refreshed. In general, issues are the best contributions. If you encounter any problems in the future, please raise an issue first before contributing code. [Sometimes there are special considerations](https://git.sheetjs.com/sheetjs/sheetjs/pulls/3202)

Sign in to join this conversation.