sheetjs
/
sheetjs
25
Fork 25
Code Issues 176 Pull Requests 12 Wiki Activity

Fix file getter: letter case do not match #440

Closed
chikh wants to merge 2 commits from fix/lower-case-files into master
pull from: fix/lower-case-files
merge into: sheetjs:master
Conversation 6 Commits 2 Files Changed 2 +16 -4
chikh commented 2016-07-15 07:49:12 +00:00 (Migrated from github.com)
Copy Link

Fixes the issue: https://github.com/SheetJS/js-xlsx/issues/439

Fixes the issue: https://github.com/SheetJS/js-xlsx/issues/439
chaliy commented 2016-09-09 13:53:45 +00:00 (Migrated from github.com)
Copy Link

Have the same issue, is there any plans to apply this pull request?

Loos like js-xlsx is not maintained any more :( . @chikh do you use some for of this, or switched to something else?

Have the same issue, is there any plans to apply this pull request? Loos like js-xlsx is not maintained any more :( . @chikh do you use some for of this, or switched to something else?
chikh commented 2016-09-09 14:33:15 +00:00 (Migrated from github.com)
Copy Link

@chaliy We've forked the repo (within private organization) and switched to this branch in our package.json. Since module is not maintained any more, it is better to find a substitution, but I can't find obvious one.

@chaliy We've forked the repo (within private organization) and switched to this branch in our `package.json`. Since module is not maintained any more, it is better to find a substitution, but I can't find obvious one.
chaliy commented 2016-09-09 14:35:08 +00:00 (Migrated from github.com)
Copy Link

@chikh aha doing the same right now. Already applied your pull request and now updating package.json. Thank you.

@chikh aha doing the same right now. Already applied your pull request and now updating package.json. Thank you.
chikh commented 2016-09-09 14:45:58 +00:00 (Migrated from github.com)
Copy Link

@chaliy You are welcome!

@chaliy You are welcome!
willgriffin commented 2016-09-09 17:13:31 +00:00 (Migrated from github.com)
Copy Link

You may have better reception submitting the pull request to

https://github.com/protobi/js-xlsx

Which is the branch I've forked and has quite a bit of further development on it

You may have better reception submitting the pull request to https://github.com/protobi/js-xlsx Which is the branch I've forked and has quite a bit of further development on it
chikh commented 2016-09-09 19:44:52 +00:00 (Migrated from github.com)
Copy Link

@willgriffin I've created PR https://github.com/protobi/js-xlsx/pull/46. I've noticed a very nice progress on the features and fixes so far!

@willgriffin I've created PR https://github.com/protobi/js-xlsx/pull/46. I've noticed a very nice progress on the features and fixes so far!

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
DBF

   
Dates

   
Defined Names

   
Features

   
Formula

   
HTML

   
Images

   
Infrastructure

   
Integration

   
International

   
ODS

   
Operations

   
Performance

   
PivotTables

   
Pro

   
Protection

   
Read Bug

   
SSF

   
SYLK

   
Style

   
Write Bug

   
good first issue
No Label
DBF
Dates
Defined Names
Features
Formula
HTML
Images
Infrastructure
Integration
International
ODS
Operations
Performance
PivotTables
Pro
Protection
Read Bug
SSF
SYLK
Style
Write Bug
good first issue
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sheetjs/sheetjs#440
No description provided.
Delete Branch "fix/lower-case-files"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?