Support cells for the 'd' date type #48

2014-02-15T00:45:34Z

hmalphettes commented

2014-02-15 00:45:34 +00:00

(Migrated from github.com)

The library we are using to generate xlsx takes advantage of the 'd' type of cell that value is an ISO8601 date.
It seems that that type had yet to be encountered in the wild by js-xlsx.
Here is a quick patch to avoid crashing the whole sheet and extract a date.

I am adding comments to the code for the parts where I think we could improve it.

I am sending you the test file by email.

The library we are using to generate xlsx takes advantage of the 'd' type of cell that value is an ISO8601 date. It seems that that type had yet to be encountered in the wild by js-xlsx. Here is a quick patch to avoid crashing the whole sheet and extract a date. I am adding comments to the code for the parts where I think we could improve it. I am sending you the test file by email.

coveralls commented

2014-02-15 00:51:27 +00:00

(Migrated from github.com)

Coverage decreased (-0.29%) when pulling e2bf43242cff5adca8b7f56b92126f3ea828356c on nerds-odd-e:Date_cell_type_support into 2cb06e0fb8 on SheetJS:master.

[![Coverage Status](https://coveralls.io/builds/520794/badge)](https://coveralls.io/builds/520794) Coverage decreased (-0.29%) when pulling **e2bf43242cff5adca8b7f56b92126f3ea828356c on nerds-odd-e:Date_cell_type_support** into **2cb06e0fb8796523642df283272b96115acbc46d on SheetJS:master**.

SheetJSDev commented

2014-02-15 05:23:07 +00:00

(Migrated from github.com)

@hmalphettes pushed in version 0.5.7

Sign in to join this conversation.

No reviewers