Unexpected BrtBigName encountered #624

New Issue

2017-04-07T13:26:14Z

pgeeh commented

2017-04-07 13:26:14 +00:00

(Migrated from github.com)

Hi,

Ran into an issue where the record type 'BrtBigName' was encountered in

parse_ws_bin > ws_parse

It appears that 'BrtBigName' is defined in XLSBRecordEnum and then is mentioned in a comment in 'write_ws_bin', but is not called out in any of the reader's methods. This throws the "Unexpected record" error in the ws_parse function.

It appears that 'BrtBigName' should be added to the list of case statements in the above method, even if it is not operated on yet.

Hi, Ran into an issue where the record type 'BrtBigName' was encountered in `parse_ws_bin > ws_parse` It appears that 'BrtBigName' is defined in XLSBRecordEnum and then is mentioned in a comment in 'write_ws_bin', but is not called out in any of the reader's methods. This throws the "Unexpected record" error in the ws_parse function. It appears that 'BrtBigName' should be added to the list of case statements in the above method, even if it is not operated on yet.

SheetJSDev commented

2017-04-07 15:39:56 +00:00

(Migrated from github.com)

@pgeeh the list in parse_ws_bin is based on records we've seen in the wild. Clearly we haven't encountered a file with a BrtBigName record! Can you possibly share a file? (if you don't want to make it public, just email us at dev at sheetjs dot com).

We'll make a release later today and try to cover more cases that the spec permits but we haven't seen yet.

@pgeeh the list in parse_ws_bin is based on records we've seen in the wild. Clearly we haven't encountered a file with a BrtBigName record! Can you possibly share a file? (if you don't want to make it public, just email us at dev at sheetjs dot com). We'll make a release later today and try to cover more cases that the spec permits but we haven't seen yet.

pgeeh commented

2017-04-07 16:42:38 +00:00

(Migrated from github.com)

@SheetJSDev unfortunately, I cannot share my workbook at this time.

https://msdn.microsoft.com/en-us/dd926172

Based on the documentation above, BrtBigName could be in the sequence of a Worksheet. It appears that is already noted in a comment in the write function 'write_ws_bin'.

@SheetJSDev unfortunately, I cannot share my workbook at this time. https://msdn.microsoft.com/en-us/dd926172 Based on the documentation above, BrtBigName could be in the sequence of a Worksheet. It appears that is already noted in a comment in the write function 'write_ws_bin'.

Sign in to join this conversation.