Style/theme implementation #66

2014-05-29T03:35:57Z

elad commented

2014-05-29 03:35:57 +00:00

(Migrated from github.com)

Initial implementation of style/theme parsing, following your input.

Experimental and guarded by the cellStyles option (default: false)

Addresses issue #36

Initial implementation of style/theme parsing, following your input. Experimental and guarded by the cellStyles option (default: false) Addresses issue #36

SheetJSDev commented

2014-05-29 03:58:44 +00:00

(Migrated from github.com)

@elad good start!

I added a few test files. In particular, take a look at https://github.com/SheetJS/test_files/raw/master/cell_style_simple.xlsx -- this has a few column styles as well as row styles, block styles and individual cell styles. Do the colors roughly line up with the sheet?

After doing all of that, please squash to one commit :)

@elad good start! I added a few test files. In particular, take a look at https://github.com/SheetJS/test_files/raw/master/cell_style_simple.xlsx -- this has a few column styles as well as row styles, block styles and individual cell styles. Do the colors roughly line up with the sheet? After doing all of that, please squash to one commit :)

elad commented

2014-05-29 04:34:02 +00:00

(Migrated from github.com)

I just realized that I only took care of fgColor and the test file had grids that required bgColor as well. After adding it, I think the colors match.

I just realized that I only took care of `fgColor` and the test file had grids that required `bgColor` as well. After adding it, I think the colors match.

elad commented

2014-05-29 05:08:12 +00:00

(Migrated from github.com)

I think I managed to squash it... Had to merge master though otherwise it wouldn't let me push.

SheetJSDev commented

2014-05-29 05:18:44 +00:00

(Migrated from github.com)

@elad Your log still shows 8 commits. You should only end up with one commit. You might need to do a git rebase followed by a git push -f.

@elad Your log still shows 8 commits. You should only end up with one commit. You might need to do a `git rebase` followed by a `git push -f`.

elad commented

2014-05-29 05:22:08 +00:00

(Migrated from github.com)

And now?

SheetJSDev commented

2014-05-29 05:26:03 +00:00

(Migrated from github.com)

Now we are down to one :)

Clean up the git message (fortunately this is just git commit --amend)

Now we are down to one :) Clean up the git message (fortunately this is just `git commit --amend`)

elad commented

2014-05-29 05:27:59 +00:00

(Migrated from github.com)

Done. :)

coveralls commented

2014-05-29 05:36:44 +00:00

(Migrated from github.com)

Changes Unknown when pulling 68dfb49bfa0b26971d259aa4b218a84e48c95fa0 on elad:master into * on SheetJS:master*.

[![Coverage Status](https://coveralls.io/builds/813961/badge)](https://coveralls.io/builds/813961) Changes Unknown when pulling **68dfb49bfa0b26971d259aa4b218a84e48c95fa0 on elad:master** into *\* on SheetJS:master**.

SheetJSDev commented

2014-05-29 06:25:41 +00:00

(Migrated from github.com)

@elad thank you very very much :)

elad commented

2014-05-29 06:26:42 +00:00

(Migrated from github.com)

You're welcome! Thank you for working on such a fantastic project! :)

Sign in to join this conversation.

No reviewers