table_to_sheet/book transforms blank cells to 0 #779
Labels
No Label
DBF
Dates
Defined Names
Features
Formula
HTML
Images
Infrastructure
Integration
International
ODS
Operations
Performance
PivotTables
Pro
Protection
Read Bug
SSF
SYLK
Style
Write Bug
good first issue
No Milestone
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: sheetjs/sheetjs#779
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This also includes cells filled with only white spaces (e.g. ' ').
Yeah, I even have this code as temporary solution:
Put the wrong number in the commit message :/ commit
2ea9c95839
resolves the issue by skipping blank cells. There are new tests for the DOM methods (using JSDOM in nodejs and the standard facilities in the browser)Thanks for the quick fix, I appreciate it!
@domxa Did this work for you in 0.11.4? I am still seeing 0's where there should be blanks or white space.
@danxfisher can you share a fiddle? https://jsfiddle.net/0w8b1qry/ appears to work
Fiddle Code (click to show)
@SheetJSDev Ah, I see what the issue is. If the formatting of the table isn't
<td></td>
on the same line but rather like this:Then it will return 0.
Fiddle: https://jsfiddle.net/b3asc8jm/
@SheetJSDev Sorry to reply to this again but just wanted to clarify: Is my above comment by design or a bug? If it's a bug, I'll create a separate issue so that this one can remain closed. Otherwise I'll try and find a workaround for my tables being generated by EJS. Thanks!
it's a bug, the uncertainty surrounded inconsistencies in how you get text data from a cell. We're testing a new technique that we should be able to push out tonight. No need to raise a new issue, although you can if you feel like :)
If there's no need, then there's no need! I am honestly baffled by the response time from the team--thanks for continuing to make everyone's life easier at such an incredible pace.
@danxfisher we suffer for the art :)