js-xlsx not support jszip 3.x #869

New Issue

2017-11-02T08:11:55Z

hstarorg commented

2017-11-02 08:11:55 +00:00

(Migrated from github.com)

In https://github.com/SheetJS/js-xlsx/blob/master/xlsx.js#L1920, there used the global JsZip lib at first. In fact, the xlsx.js all packed the jszip 2.x, so I think use global jszip is unnecessary.

In my project, I used the JsZip as global variable, so the xlsx has a compatibility question.(not support jszip 3.x)

In `https://github.com/SheetJS/js-xlsx/blob/master/xlsx.js#L1920`, there used the global JsZip lib at first. In fact, the `xlsx.js` all packed the jszip 2.x, so I think use global jszip is unnecessary. In my project, I used the JsZip as global variable, so the xlsx has a compatibility question.(not support jszip 3.x)

reviewher commented

2017-11-02 15:26:40 +00:00

(Migrated from github.com)

JSZip 3.x removed critical features that we use, so you have to use 2.x.

Due to other changes, the script is included in the node module and the dist xlsx.full.min.js ships with a version of JSZip that plays nice.

JSZip 3.x removed critical features that we use, so you have to use 2.x. Due to other changes, the script is included in the node module and the dist `xlsx.full.min.js` ships with a version of JSZip that plays nice.

👎 2

hstarorg commented

2017-11-03 03:25:19 +00:00

(Migrated from github.com)

Though the dist xlsx.full.min.js ships with a version of JSZip, the xlsx have priority use the global JsZip.
See code : https://github.com/SheetJS/js-xlsx/blob/master/xlsx.js#L1932

Though the dist `xlsx.full.min.js` ships with a version of JSZip, the xlsx have priority use the global JsZip. See code : [https://github.com/SheetJS/js-xlsx/blob/master/xlsx.js#L1932](https://github.com/SheetJS/js-xlsx/blob/master/xlsx.js#L1932)

👍 1

martinnov92 commented

2017-11-09 06:57:18 +00:00

(Migrated from github.com)

Can you reopen this issue please? Even when using xlsx.full.min.js it is not working

Can you reopen this issue please? Even when using `xlsx.full.min.js` it is not working

hstarorg commented

2017-11-09 07:08:19 +00:00

(Migrated from github.com)

@martinnov92 In my project, I removed the code that use global JsZip.

martinnov92 commented

2017-11-09 08:04:33 +00:00