Missing shim.js from npm release #911

New Issue

2017-12-03T12:55:56Z

dackmin commented

2017-12-03 12:55:56 +00:00

(Migrated from github.com)

Hi guys,

Despite clearly understanding that shim.js is not needed when running js-xlsx as a node module, as we are all slowly removing bower from all our projects and moving to yarn, I think it still needs to be part of the npm release (e.g removed from .npmignore) so we can use it for front-end projects without using bower anymore.

Any thought/opposition about/to this ?

Hi guys, Despite clearly understanding that `shim.js` is not needed when running `js-xlsx` as a node module, as we are all slowly removing bower from all our projects and moving to yarn, I think it still needs to be part of the npm release (e.g removed from `.npmignore`) so we can use it for front-end projects without using bower anymore. Any thought/opposition about/to this ?

SheetJSDev commented

2017-12-04 01:19:28 +00:00

(Migrated from github.com)

The minified dist files are in the node module so we might as well include the shim. It'll be in the next release.

🎉 1

Sign in to join this conversation.