Sourcemap defined in jszip.js breaks IE compatible < version 11 #98

New Issue

2014-08-21T06:40:36Z

xuqingkuang commented

2014-08-21 06:40:36 +00:00

(Migrated from github.com)

In following lines of jszip.js, the source map definition breaks javascript execution in IE < ver 11:

https://github.com/SheetJS/js-xlsx/blob/master/jszip.js#L1512
https://github.com/SheetJS/js-xlsx/blob/master/jszip.js#L1573

IE console reports 'rawdeflate is undefined'

Please change them to be

/*
//@ sourceMappingURL=rawdeflate.min.js.map
*/

Or dump to latest jszip version.

In following lines of jszip.js, the source map definition breaks javascript execution in IE < ver 11: https://github.com/SheetJS/js-xlsx/blob/master/jszip.js#L1512 https://github.com/SheetJS/js-xlsx/blob/master/jszip.js#L1573 IE console reports 'rawdeflate is undefined' Please change them to be /* //@ sourceMappingURL=rawdeflate.min.js.map */ Or dump to latest jszip version.

SheetJSDev commented

2014-08-21 08:19:04 +00:00

(Migrated from github.com)

@xuqingkuang Does it break execution or merely issue a warning? I tested http://oss.sheetjs.com/js-xlsx against various versions of IE in the past and didn't encounter a functional error. Regardless, we definitely should look into updating the jszip dependency

xuqingkuang commented

2014-08-21 10:06:32 +00:00

(Migrated from github.com)

@SheetJSDev Yes, it breaks execution. Our app is using js-xlsx with bower, referenced the built-in jszip.js, only IE can't run with this issue.

Here's another ticket of jQuery that have same situation - http://bugs.jquery.com/ticket/13274

@SheetJSDev Yes, it breaks execution. Our app is using js-xlsx with bower, referenced the built-in jszip.js, only IE can't run with this issue. Here's another ticket of jQuery that have same situation - http://bugs.jquery.com/ticket/13274

SheetJSDev commented

2014-08-21 16:03:29 +00:00

(Migrated from github.com)

@xuqingkuang After issues like https://github.com/Stuk/jszip/issues/126, I'm somewhat concerned about upgrading jszip. Fortunately I haven't encountered any issues with this update against our test suite.