Supporting skipping hidden columns and rows in sheet_to_json #2395

Closed
geniejhang wants to merge 0 commits from master into master
geniejhang commented 2021-09-22 07:13:47 +00:00 (Migrated from github.com)

Simple copy and paste from sheet_to_csv to support skipping hidden columns and rows in sheet_to_json function.

Simple copy and paste from sheet_to_csv to support skipping hidden columns and rows in sheet_to_json function.
geniejhang commented 2021-10-08 15:03:11 +00:00 (Migrated from github.com)

Looks like no one is interested :)

Looks like no one is interested :)
SheetJSDev commented 2021-10-08 18:47:43 +00:00 (Migrated from github.com)

Just out of curiosity, what does/should happen if the first row is hidden and that row contains the keys? Should keys be read from the first visible row in the range? Should it just read that row anyway?

Just out of curiosity, what does/should happen if the first row is hidden and that row contains the keys? Should keys be read from the first visible row in the range? Should it just read that row anyway?
geniejhang commented 2021-10-08 18:51:16 +00:00 (Migrated from github.com)

I haven't tested the situation, but I think we need to assume users should be reasonable.
They should be unhide the row/column if they want to read those.
So, I think it just read the visible stuff when skipHidden option is enabled.

I haven't tested the situation, but I think we need to assume users should be reasonable. They should be unhide the row/column if they want to read those. So, I think it just read the visible stuff when skipHidden option is enabled.
arnonrdp commented 2022-01-06 19:50:17 +00:00 (Migrated from github.com)

I can't understand why this is not merged yet.

I can't understand why this is not merged yet.
geniejhang commented 2022-01-06 21:10:15 +00:00 (Migrated from github.com)

@SheetJSDev @arnonrdp Me, neither.

@SheetJSDev @arnonrdp Me, neither.
geniejhang commented 2022-01-12 17:30:32 +00:00 (Migrated from github.com)

Latest commit is for bug fix

Latest commit is for bug fix
reviewher commented 2022-03-09 10:48:37 +00:00 (Migrated from github.com)

This PR would close #1280

This PR would close #1280
reviewher commented 2022-03-12 00:26:52 +00:00 (Migrated from github.com)
[0270784](https://github.com/SheetJS/sheetjs/commit/02707848ad3fa7713db4d7864cb80f4616d0b360)

Pull request closed

Sign in to join this conversation.
No description provided.