fix tests re #2763 #2762 #2764

2022-08-08T21:02:04Z

AbdelrahmanHafez commented

2022-08-08 21:02:04 +00:00

(Migrated from github.com)

#2673 was merged with a few failing tests due to a v value in the sheets being added to random rows, causing the tests to fail.

So to get consistent results, I am converting the sheet to json, and asserting against that JSON value.
Let's wait and see if all the tests pass on the pipeline, then we can merge.

#2673 was merged with a few failing tests due to a `v` value in the sheets being added to random rows, causing the tests to fail. So to get consistent results, I am converting the sheet to json, and asserting against that JSON value. Let's wait and see if all the tests pass on the pipeline, then we can merge.

SheetJSDev commented

2022-08-09 00:20:54 +00:00

(Migrated from github.com)

Simplified the test a bit (reused the base64 string and added the application/vnd.ms-excel type) and updated the other tests. The browser tests also pass https://app.saucelabs.com/builds/vdc/d0856e046ac93728ab5734c276f0ca89

Simplified the test a bit (reused the base64 string and added the `application/vnd.ms-excel` type) and updated the other tests. The browser tests also pass https://app.saucelabs.com/builds/vdc/d0856e046ac93728ab5734c276f0ca89

AbdelrahmanHafez commented

2022-08-09 00:34:06 +00:00

(Migrated from github.com)

Thanks @SheetJSDev 👍