CSV export can now be cleansed from new lines and trailing spaces #871

2017-11-03T08:30:51Z

const-g commented

2017-11-03 08:30:51 +00:00

(Migrated from github.com)

Added an option --clean to make CSV export to remove new lines from cell content, and trim the content also

Added an option `--clean` to make CSV export to remove new lines from cell content, and trim the content also

SheetJSDev commented

2017-11-03 17:00:38 +00:00

(Migrated from github.com)

@const-g overall makes sense, but there are a few comments:

should this also apply to other formats, or is this appropriate only for CSV / TXT?
https://docs.sheetjs.com/#delimiter-separated-output there are other options that are not exposed to the CLI, namely strip and blankrows. The "strip" option removes trailing delimiters (foo,bar,, -> foo,bar) and "blankrows" omits blank rows. Should those also be set under --clean?
Your editor also made a bunch of changes to package.json :( can you revert them?
Can you undo all of the whitespace changes to bits/90_utils.js and re-make?
We'd prefer the commit one-line summary to be within 50 characters. Can you change the message to something like:

Plaintext export "clean" option and CLI "--clean"

Clean removes newlines and trims

@const-g overall makes sense, but there are a few comments: 1) should this also apply to other formats, or is this appropriate only for CSV / TXT? 2) https://docs.sheetjs.com/#delimiter-separated-output there are other options that are not exposed to the CLI, namely `strip` and `blankrows`. The "strip" option removes trailing delimiters (`foo,bar,,` -> `foo,bar`) and "blankrows" omits blank rows. Should those also be set under `--clean`? 3) Your editor also made a bunch of changes to package.json :( can you revert them? 4) Can you undo all of the whitespace changes to bits/90_utils.js and re-make? 5) We'd prefer the commit one-line summary to be within 50 characters. Can you change the message to something like: ``` Plaintext export "clean" option and CLI "--clean" Clean removes newlines and trims ```

SheetJSDev commented

2021-09-15 07:37:42 +00:00

(Migrated from github.com)

If you can explain why this is interesting/useful we will reconsider merging.