sheetjs/bessel
1
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Avoid modifying the Array.prototype; add a test for each bessel function #1

Merged
hmalphettes merged 1 commits from master into master 2014-08-04 03:03:01 +00:00
Conversation 2 Commits 1 Files Changed 2 +46 -26
hmalphettes commented 2014-08-04 01:36:30 +00:00 (Migrated from github.com)
Copy Link

Hi @SheetJSDev, we are looking at using your implementation of the bessel's functions in formulajs: https://github.com/sutoiku/formula.js/issues/24

Here is the one modification we wanted to make: avoid modifying the Array prototype.
We added a test for each one of the functions.

Hi @SheetJSDev, we are looking at using your implementation of the bessel's functions in formulajs: https://github.com/sutoiku/formula.js/issues/24 Here is the one modification we wanted to make: avoid modifying the Array prototype. We added a test for each one of the functions.
SheetJSDev commented 2014-08-04 03:04:57 +00:00 (Migrated from github.com)
Copy Link

@hmalphettes Thanks for identifying and fixing the problem!

@hmalphettes Thanks for identifying and fixing the problem!
hmalphettes commented 2014-08-04 03:13:38 +00:00 (Migrated from github.com)
Copy Link

Cheers!

Cheers!
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
invalid

   
question

   
wontfix
No Label
bug
duplicate
enhancement
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sheetjs/bessel#1
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?