sheetjs/bessel
1
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

No need to depend on voc #2

Closed
hmalphettes wants to merge 1 commits from master into master
pull from: master
merge into: sheetjs:master
Conversation 4 Commits 1 Files Changed 3 +2 -2
hmalphettes commented 2014-08-07 05:43:27 +00:00 (Migrated from github.com)
Copy Link

Hi again!
Just curious: why does bessel depends on voc?
The tests are passing without it.
I could not figure out where it is used.
Thanks!

Hi again! Just curious: why does bessel depends on voc? The tests are passing without it. I could not figure out where it is used. Thanks!
hmalphettes commented 2014-08-07 05:49:51 +00:00 (Migrated from github.com)
Copy Link

Actually... I just figured it out: it is used to process the README file.
I am preparing a PR for the next refactored formulajs where we dont copy paste code: we will depend directly on bessel installed via npm.
It is really a detail but I think it would be better to not have voc installed in the production dependencies.
Cheers!

Actually... I just figured it out: it is used to process the README file. I am preparing a PR for the next refactored formulajs where we dont copy paste code: we will depend directly on bessel installed via npm. It is really a detail but I think it would be better to not have voc installed in the production dependencies. Cheers!
hmalphettes commented 2014-08-07 05:57:38 +00:00 (Migrated from github.com)
Copy Link

... and added a 3rd commit totally unrelated: the bessely test had the proper label but was running the besselk code. Sorry about that.

... and added a 3rd commit totally unrelated: the bessely test had the proper label but was running the besselk code. Sorry about that.
SheetJSDev commented 2014-08-10 14:25:00 +00:00 (Migrated from github.com)
Copy Link

@hmalphettes can you squash it down to one commit?

@hmalphettes can you squash it down to one commit?
hmalphettes commented 2014-08-11 02:36:59 +00:00 (Migrated from github.com)
Copy Link

@SheetJSDev squashed!

@SheetJSDev squashed!

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
invalid

   
question

   
wontfix
No Label
bug
duplicate
enhancement
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sheetjs/bessel#2
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?