sheetjs
/
js-adler32
1
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Refactored CLI to separate npm package #4

Merged
garrettluu merged 1 commits from master into master 2020-06-27 23:54:09 +00:00
Conversation 2 Commits 1 Files Changed 6 +116 -90
garrettluu commented 2020-06-25 19:22:25 +00:00 (Migrated from github.com)
Copy Link

Addresses this issue.

Moved CLI into its own package, located in packages/adler32-cli. Published NPM package here

Addresses [this issue](https://github.com/SheetJS/sheetjs/issues/1922). Moved CLI into its own package, located in `packages/adler32-cli`. Published NPM package [here](https://www.npmjs.com/package/adler32-cli)
srijonsaha (Migrated from github.com) reviewed 2020-06-25 19:22:25 +00:00
coveralls commented 2020-06-25 19:34:04 +00:00 (Migrated from github.com)
Copy Link

Coverage Status

Coverage remained the same at 88.71% when pulling b40011c6f7 on garrettluu:master into d747eda300 on SheetJS:master.

[![Coverage Status](https://coveralls.io/builds/31692839/badge)](https://coveralls.io/builds/31692839) Coverage remained the same at 88.71% when pulling **b40011c6f76bb2a0b78126fc8412ff380c905dcd on garrettluu:master** into **d747eda300a84a2539dd2b713d06cf28ef27c08a on SheetJS:master**.
stof commented 2020-07-16 10:01:46 +00:00 (Migrated from github.com)
Copy Link

this misses the removal of the exit-on-epipe and printj dependencies from the adler32 package (as they are only used by the CLI)

this misses the removal of the `exit-on-epipe` and `printj` dependencies from the `adler32` package (as they are only used by the CLI)
Sign in to join this conversation.
Reviewers
No reviewers
srijonsaha
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
help wanted

   
invalid

   
question

   
wontfix
No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sheetjs/js-adler32#4
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?