Fixes #5 #6

Merged
rossj merged 1 commits from master into master 2019-06-10 12:45:17 +00:00
rossj commented 2018-12-12 19:29:12 +00:00 (Migrated from github.com)

This update fixes issue #5 when resolving full path names by allowing traversing to the root node. Previously, traversal would stop when j === 0 or j === dad[j], both of which are true for the root node.

This update fixes issue #5 when resolving full path names by allowing traversing to the root node. Previously, traversal would stop when `j === 0` or `j === dad[j]`, both of which are true for the root node.
SheetJSDev commented 2019-06-10 12:41:59 +00:00 (Migrated from github.com)

There's a small issue where if an element is its own parent, then the loop will not terminate. That will be fixed in a separate commit

There's a small issue where if an element is its own parent, then the loop will not terminate. That will be fixed in a separate commit
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sheetjs/js-cfb#6
No description provided.