sheetjs/js-codepage
1
Fork 0
Code Issues 5 Pull Requests 1 Projects Releases Wiki Activity

remove unneeded len assign #8

Closed
zetxx wants to merge 1 commits from master into master
pull from: master
merge into: sheetjs:master
Conversation 1 Commits 1 Files Changed 1 -1
zetxx commented 2015-09-18 09:06:22 +00:00 (Migrated from github.com)
Copy Link

why you assigning out.length = ... when on next line you are slicing it and overwrite the out whit the sliced one

why you assigning out.length = ... when on next line you are slicing it and overwrite the out whit the sliced one
SheetJSDev commented 2016-01-16 03:59:10 +00:00 (Migrated from github.com)
Copy Link

This should be fixed in version 1.4.0

This should be fixed in version 1.4.0

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
invalid

   
question

   
wontfix
No Label
bug
duplicate
enhancement
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sheetjs/js-codepage#8
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?