node 4.2.1: Don't manually define length of Buffers #9

2015-10-20T18:10:38Z

mikkeloscar commented

2015-10-20 18:10:38 +00:00

(Migrated from github.com)

It is undefined to define the length on an already allocated Buffer.
This removes any instances of that and makes sure to return a buffer of the expected length.

This also allows js-codepage to work with the latest version of node.

I know a few similar PR has been made, but this one aims to solve all of the related issues.

It is undefined to define the length on an already allocated Buffer. This removes any instances of that and makes sure to return a buffer of the expected length. This also allows js-codepage to work with the latest version of node. I know a few similar PR has been made, but this one aims to solve all of the related issues.

mikkeloscar commented

2015-11-26 15:00:04 +00:00

(Migrated from github.com)

Hello, could you give me a status on this? I'm more than happy to change anything if needed.

Also note that the travis build only failed because of a timeout in the build, so it is passing if travis isn't slow. :)

Hello, could you give me a status on this? I'm more than happy to change anything if needed. Also note that the travis build only failed because of a timeout in the build, so it is passing if travis isn't slow. :)

SheetJSDev commented

2016-01-16 03:58:28 +00:00

(Migrated from github.com)

@mikkeloscar sorry for the delay, the current version (where all manual length assignments were replaced with slices) passes all of the tests in node 0.8 through 5.0 and has been pushed as version 1.4.0

mikkeloscar commented

2016-01-16 04:18:04 +00:00

(Migrated from github.com)

Thanks!