sheetjs
/
js-crc32
1
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Refactored CLI #15

Closed
garrettluu wants to merge 1 commits from master into master
pull from: master
merge into: sheetjs:master
Conversation 6 Commits 1 Files Changed 5 +116 -87
garrettluu commented 2020-06-25 23:53:23 +00:00 (Migrated from github.com)
Copy Link

Addresses this issue.

Moved CLI into a separate package located in packages/crc32-cli. Published npm package here.

Addresses [this issue](https://github.com/SheetJS/sheetjs/issues/1922). Moved CLI into a separate package located in `packages/crc32-cli`. Published npm package [here](https://www.npmjs.com/package/crc32-cli).
coveralls commented 2020-06-26 00:03:26 +00:00 (Migrated from github.com)
Copy Link

Coverage Status

Coverage remained the same at 91.358% when pulling eaabd0c8fc on garrettluu:master into 0d509b2f91 on SheetJS:master.

[![Coverage Status](https://coveralls.io/builds/31697815/badge)](https://coveralls.io/builds/31697815) Coverage remained the same at 91.358% when pulling **eaabd0c8fceab4c0b8548eb02af926135aa916a4 on garrettluu:master** into **0d509b2f91294dfbff3ce3647e762a2a73bfc689 on SheetJS:master**.
srijonsaha (Migrated from github.com) approved these changes 2020-06-29 18:46:29 +00:00
stof commented 2020-07-16 10:02:51 +00:00 (Migrated from github.com)
Copy Link

This misses the removal of CLI-only dependencies from the package.json of the crc32 package (which is the main reason for the refactoring)

This misses the removal of CLI-only dependencies from the package.json of the crc32 package (which is the main reason for the refactoring)
stof commented 2021-11-15 17:34:40 +00:00 (Migrated from github.com)
Copy Link

@garrettluu @srijonsaha what is the state of this work ?

@garrettluu @srijonsaha what is the state of this work ?
stof commented 2022-02-14 16:24:23 +00:00 (Migrated from github.com)
Copy Link

@SheetJSDev any news on this ?

@SheetJSDev any news on this ?
stof commented 2022-03-30 18:15:51 +00:00 (Migrated from github.com)
Copy Link

@SheetJSDev any chance to have this merged ? This is the last package where the CLI is not split yet IIRC.

@SheetJSDev any chance to have this merged ? This is the last package where the CLI is not split yet IIRC.
SheetJSDev commented 2022-04-04 22:20:27 +00:00 (Migrated from github.com)
Copy Link

We'll split the difference: keep the bin-script but refactor to remove the dependencies. The CLI script has been added to the repo in a commit attributed to @garrettluu

We'll split the difference: keep the bin-script but refactor to remove the dependencies. The CLI script has been added to the repo in a commit attributed to @garrettluu

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
srijonsaha
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
good first issue

   
help wanted

   
invalid

   
question

   
wontfix
No Label
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sheetjs/js-crc32#15
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?