Use str.repeat instead of substr for padding #5

2018-10-19T08:06:32Z

pimlie commented

2018-10-19 08:06:32 +00:00

(Migrated from github.com)

feat: use str.repeat for padding (fixes #4)
feat: add str.repeat polyfill for older browsers
feat: add module field to package.json

The polyfill is not included in the esm build, esm always support str.repeat.

feat: use str.repeat for padding (fixes #4) feat: add str.repeat polyfill for older browsers feat: add module field to package.json The polyfill is not included in the esm build, esm always support str.repeat.

coveralls commented

2018-10-19 08:13:29 +00:00

(Migrated from github.com)

Coverage decreased (-1.2%) to 95.28% when pulling 860f1ed9e6 on pimlie:feat-str-repeat into e1e33f9cb6 on SheetJS:master.

[![Coverage Status](https://coveralls.io/builds/19610946/badge)](https://coveralls.io/builds/19610946) Coverage decreased (-1.2%) to 95.28% when pulling **860f1ed9e64ad826a3e364e68001e6e6c831a3c8 on pimlie:feat-str-repeat** into **e1e33f9cb6daeb055694631760d5e7e3cdd8dbcb on SheetJS:master**.

pimlie commented

2018-10-19 09:09:56 +00:00

(Migrated from github.com)

If you dont like the polyfill I could also add a simple check like typeof c.repeat === "function" so we can at least fix the issue for newer browsers

If you dont like the polyfill I could also add a simple check like `typeof c.repeat === "function"` so we can at least fix the issue for newer browsers

SheetJSDev commented

2018-10-19 15:19:23 +00:00

(Migrated from github.com)

Thanks a lot! The IE15+ issues triggered by a browser bug -- see https://github.com/Microsoft/ChakraCore/issues/3929 for further discussion.

We will likely move that shim to the actual shim source shim.js before publishing the next version

Thanks a lot! The IE15+ issues triggered by a browser bug -- see https://github.com/Microsoft/ChakraCore/issues/3929 for further discussion. We will likely move that shim to the actual shim source `shim.js` before publishing the next version

Sign in to join this conversation.

No reviewers