sheetjs/printj
1
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Use str.repeat instead of substr for padding #5

Merged
pimlie merged 1 commits from feat-str-repeat into master 2018-10-19 15:19:35 +00:00
Conversation 3 Commits 1 Files Changed 4 +41 -8
pimlie commented 2018-10-19 08:06:32 +00:00 (Migrated from github.com)
Copy Link

feat: use str.repeat for padding (fixes #4)
feat: add str.repeat polyfill for older browsers
feat: add module field to package.json

The polyfill is not included in the esm build, esm always support str.repeat.

feat: use str.repeat for padding (fixes #4) feat: add str.repeat polyfill for older browsers feat: add module field to package.json The polyfill is not included in the esm build, esm always support str.repeat.
coveralls commented 2018-10-19 08:13:29 +00:00 (Migrated from github.com)
Copy Link

Coverage Status

Coverage decreased (-1.2%) to 95.28% when pulling 860f1ed9e6 on pimlie:feat-str-repeat into e1e33f9cb6 on SheetJS:master.

[![Coverage Status](https://coveralls.io/builds/19610946/badge)](https://coveralls.io/builds/19610946) Coverage decreased (-1.2%) to 95.28% when pulling **860f1ed9e64ad826a3e364e68001e6e6c831a3c8 on pimlie:feat-str-repeat** into **e1e33f9cb6daeb055694631760d5e7e3cdd8dbcb on SheetJS:master**.
pimlie commented 2018-10-19 09:09:56 +00:00 (Migrated from github.com)
Copy Link

If you dont like the polyfill I could also add a simple check like typeof c.repeat === "function" so we can at least fix the issue for newer browsers

If you dont like the polyfill I could also add a simple check like `typeof c.repeat === "function"` so we can at least fix the issue for newer browsers
SheetJSDev commented 2018-10-19 15:19:23 +00:00 (Migrated from github.com)
Copy Link

Thanks a lot! The IE15+ issues triggered by a browser bug -- see https://github.com/Microsoft/ChakraCore/issues/3929 for further discussion.

We will likely move that shim to the actual shim source shim.js before publishing the next version

Thanks a lot! The IE15+ issues triggered by a browser bug -- see https://github.com/Microsoft/ChakraCore/issues/3929 for further discussion. We will likely move that shim to the actual shim source `shim.js` before publishing the next version
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
help wanted

   
invalid

   
question

   
wontfix
No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sheetjs/printj#5
No description provided.
Delete Branch "feat-str-repeat"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?