Update the Electron Demo #1980

2020-06-04T21:40:00Z

ianjennings commented

2020-06-04 21:40:00 +00:00

(Migrated from github.com)

Made in collaboration with @Shraddha2104 as part of the MLH fellowship.

This pull request updates the Electron SheetJS demo from v1.7 to v9.0.2.

Note that Electron now requires nodeIntegration: true in order to require('XLSX') in the renderer process. Read more about nodeIntegration security here.

Made in collaboration with @Shraddha2104 as part of the MLH fellowship. This pull request updates the Electron SheetJS demo from `v1.7` to `v9.0.2`. Note that Electron now requires `nodeIntegration: true` in order to `require('XLSX')` in the renderer process. Read more about nodeIntegration security [here](https://www.electronjs.org/docs/tutorial/security#isolation-for-untrusted-content). ![image](https://user-images.githubusercontent.com/318295/83812949-051d7f80-a682-11ea-8d7a-7c35ee11845d.png)

SheetJSDev commented

2020-06-04 22:12:50 +00:00

(Migrated from github.com)

Can you also change the README to reflect the electron version?

garrettluu commented

2020-06-12 19:42:38 +00:00

(Migrated from github.com)

Be sure to squash commits and add [ci skip] to your commit message to avoid Travis CI checks!

Be sure to squash commits and add `[ci skip]` to your commit message to avoid Travis CI checks!

srijonsaha commented

2020-06-26 06:01:01 +00:00

(Migrated from github.com)