Update electron demo #2027

2020-06-26T06:00:06Z

srijonsaha commented

2020-06-26 06:00:06 +00:00

(Migrated from github.com)

Continuing from #1980 fixing the commented issues. Closes #1981. Addresses #1994 as well.

garrettluu (Migrated from github.com) reviewed 2020-06-26 18:18:10 +00:00

garrettluu (Migrated from github.com) left a comment

Looks good so far! I'll pull your changes and try to run the demo.

SheetJSDev (Migrated from github.com) reviewed 2020-06-26 18:25:41 +00:00

garrettluu commented

2020-06-26 18:57:03 +00:00

(Migrated from github.com)

Ran the demo and got an error when I tried to click the "click here to select a file" button:

index.js:68 Uncaught (in promise) TypeError: Cannot read property 'showOpenDialog' of undefined
    at HTMLButtonElement.handleF (index.js:68)

Ran the demo and got an error when I tried to click the "click here to select a file" button: ``` index.js:68 Uncaught (in promise) TypeError: Cannot read property 'showOpenDialog' of undefined at HTMLButtonElement.handleF (index.js:68) ```

SheetJSDev commented

2020-06-26 19:10:51 +00:00

(Migrated from github.com)

@garrettluu what OS / electron version are you using?

garrettluu commented

2020-06-26 19:31:25 +00:00

(Migrated from github.com)

@garrettluu what OS / electron version are you using?

Electron 9.0.5, Ubuntu 20.04

> @garrettluu what OS / electron version are you using? Electron 9.0.5, Ubuntu 20.04

srijonsaha commented

2020-06-26 19:38:26 +00:00

(Migrated from github.com)

Ran the demo and got an error when I tried to click the "click here to select a file" button:
index.js:68 Uncaught (in promise) TypeError: Cannot read property 'showOpenDialog' of undefined
    at HTMLButtonElement.handleF (index.js:68)

@garrettluu I pushed in a fix for this. Can you try again?

> Ran the demo and got an error when I tried to click the "click here to select a file" button: > > ``` > index.js:68 Uncaught (in promise) TypeError: Cannot read property 'showOpenDialog' of undefined > at HTMLButtonElement.handleF (index.js:68) > ``` @garrettluu I pushed in a fix for this. Can you try again?

garrettluu commented

2020-06-26 19:42:02 +00:00

(Migrated from github.com)

Ran the demo and got an error when I tried to click the "click here to select a file" button:
index.js:68 Uncaught (in promise) TypeError: Cannot read property 'showOpenDialog' of undefined
    at HTMLButtonElement.handleF (index.js:68)
@garrettluu I pushed in a fix for this. Can you try again?

@srijonsaha Works for me now! Thanks!

> > Ran the demo and got an error when I tried to click the "click here to select a file" button: > > ``` > > index.js:68 Uncaught (in promise) TypeError: Cannot read property 'showOpenDialog' of undefined > > at HTMLButtonElement.handleF (index.js:68) > > ``` > > @garrettluu I pushed in a fix for this. Can you try again? @srijonsaha Works for me now! Thanks!

garrettluu (Migrated from github.com) approved these changes 2020-06-26 19:42:13 +00:00

Sign in to join this conversation.

No reviewers

garrettluu