sheetjs
/
sheetjs
24
Fork 25
Code Issues 176 Pull Requests 12 Wiki Activity

browser test cleanup #2039

Merged
wlawt merged 3 commits from browser_mft_tests into master 2020-07-02 19:57:21 +00:00
Conversation 2 Commits 3 Files Changed 4 +131 -15
wlawt commented 2020-07-01 16:50:45 +00:00 (Migrated from github.com)
Copy Link

Browser tests was missing ~77 (344) tests compared to the nodejs tests (421).

A lot of them were MFT tests, that I've added in tests/fixtures.lst

After adding the MFT tests, browser tests now covers 403 tests.

Browser tests was missing ~77 (344) tests compared to the nodejs tests (421). A lot of them were MFT tests, that I've added in `tests/fixtures.lst` After adding the MFT tests, browser tests now covers 403 tests.
SheetJSDev commented 2020-07-01 18:16:59 +00:00 (Migrated from github.com)
Copy Link

the 14.x build issues appear to be a node v14.5.0 regression https://github.com/nodejs/node/issues/34162, ignore those for the moment

the 14.x build issues appear to be a node v14.5.0 regression https://github.com/nodejs/node/issues/34162, ignore those for the moment
penguingovernor (Migrated from github.com) requested changes 2020-07-01 22:54:18 +00:00
penguingovernor (Migrated from github.com) left a comment
Copy Link

Looks good to me sans that one little debugging remnant, other than that good work (:

Looks good to me sans that one little debugging remnant, other than that good work (:
penguingovernor (Migrated from github.com) reviewed 2020-07-01 22:58:17 +00:00
penguingovernor commented 2020-07-02 19:57:11 +00:00 (Migrated from github.com)
Copy Link

Cool thanks for doing this y'all! Looks great!

Cool thanks for doing this y'all! Looks great!
Sign in to join this conversation.
Reviewers
No reviewers
penguingovernor
Labels
Clear labels   
DBF

   
Dates

   
Defined Names

   
Features

   
Formula

   
HTML

   
Images

   
Infrastructure

   
Integration

   
International

   
ODS

   
Operations

   
Performance

   
PivotTables

   
Pro

   
Protection

   
Read Bug

   
SSF

   
SYLK

   
Style

   
Write Bug

   
good first issue
No Label
DBF
Dates
Defined Names
Features
Formula
HTML
Images
Infrastructure
Integration
International
ODS
Operations
Performance
PivotTables
Pro
Protection
Read Bug
SSF
SYLK
Style
Write Bug
good first issue
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sheetjs/sheetjs#2039
No description provided.
Delete Branch "browser_mft_tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?