browser test cleanup #2039

2020-07-01T16:50:45Z

wlawt commented

2020-07-01 16:50:45 +00:00

(Migrated from github.com)

Browser tests was missing ~77 (344) tests compared to the nodejs tests (421).

A lot of them were MFT tests, that I've added in tests/fixtures.lst

After adding the MFT tests, browser tests now covers 403 tests.

Browser tests was missing ~77 (344) tests compared to the nodejs tests (421). A lot of them were MFT tests, that I've added in `tests/fixtures.lst` After adding the MFT tests, browser tests now covers 403 tests.

SheetJSDev commented

2020-07-01 18:16:59 +00:00

(Migrated from github.com)

the 14.x build issues appear to be a node v14.5.0 regression https://github.com/nodejs/node/issues/34162, ignore those for the moment

penguingovernor (Migrated from github.com) requested changes 2020-07-01 22:54:18 +00:00

penguingovernor (Migrated from github.com) left a comment

Looks good to me sans that one little debugging remnant, other than that good work (:

penguingovernor (Migrated from github.com) reviewed 2020-07-01 22:58:17 +00:00

penguingovernor commented

2020-07-02 19:57:11 +00:00

(Migrated from github.com)

Cool thanks for doing this y'all! Looks great!

Sign in to join this conversation.

No reviewers

penguingovernor

No Label

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sheetjs/sheetjs#2039