Update xlsx.js #116

2014-09-18T16:40:10Z

OlafurTorfi commented

2014-09-18 16:40:10 +00:00

(Migrated from github.com)

JSZip written with capitals in jszip.js and lower case in xlsx.js...

SheetJSDev commented

2014-09-18 18:18:36 +00:00

(Migrated from github.com)

This is intentional. There were three contexts which accessed JSZip in different ways:

In the browser, the JSZip global variable is available.
In NodeJS you have to require it.
In PyV8 contexts an older version of JSZip was used, which required a different variable.

To avoid global variable use in other parts of the code, a different local variable is used (putting "var JSZip" in the code would mask the JSZip variable from the other source file when used in browser)

If you scroll up in the file, you will see a part where jszip is assigned.

Sent from my iPad

On Sep 18, 2014, at 12:40 PM, Ólafur Torfi Yngvason notifications@github.com wrote:

JSZip written with capitals in jszip.js and lower case in xlsx.js...

You can merge this Pull Request by running

git pull https://github.com/OlafurTorfi/js-xlsx master
Or view, comment on, or merge it at:

https://github.com/SheetJS/js-xlsx/pull/116

Commit Summary

Update xlsx.js
File Changes

M xlsx.js (10)
Patch Links:

https://github.com/SheetJS/js-xlsx/pull/116.patch
https://github.com/SheetJS/js-xlsx/pull/116.diff
—
Reply to this email directly or view it on GitHub.

This is intentional. There were three contexts which accessed JSZip in different ways: - In the browser, the JSZip global variable is available. - In NodeJS you have to require it. - In PyV8 contexts an older version of JSZip was used, which required a different variable. To avoid global variable use in other parts of the code, a different local variable is used (putting "var JSZip" in the code would mask the JSZip variable from the other source file when used in browser) If you scroll up in the file, you will see a part where jszip is assigned. Sent from my iPad > On Sep 18, 2014, at 12:40 PM, Ólafur Torfi Yngvason notifications@github.com wrote: > > JSZip written with capitals in jszip.js and lower case in xlsx.js... > > You can merge this Pull Request by running > > git pull https://github.com/OlafurTorfi/js-xlsx master > Or view, comment on, or merge it at: > > https://github.com/SheetJS/js-xlsx/pull/116 > > Commit Summary > > Update xlsx.js > File Changes > > M xlsx.js (10) > Patch Links: > > https://github.com/SheetJS/js-xlsx/pull/116.patch > https://github.com/SheetJS/js-xlsx/pull/116.diff > — > Reply to this email directly or view it on GitHub.

lrdevries commented

2015-06-01 14:54:56 +00:00

(Migrated from github.com)

Je problem isn't that JSZip is or isn't in capitils, the problem is that in bower.json jszip isn't a dependency of js-xlsx. Therefore if you handle your dependencies automatic, the order of the files isn't correct, because it loads js-xlsx before jszip.

reviewher commented

2017-02-28 10:36:07 +00:00

(Migrated from github.com)

@lrdevries the bower entry point has been changed to a script that embeds the jszip dependency directly.

Closing because I think the underlying issue was resolved, please raise a new issue if it is still a problem

@lrdevries the bower entry point has been changed to a script that embeds the jszip dependency directly. Closing because I think the underlying issue was resolved, please raise a new issue if it is still a problem