fix parse_si for Japanese excel files #141

2014-10-30T06:07:55Z

tgfjt commented

2014-10-30 06:07:55 +00:00

(Migrated from github.com)

Hi.

using #parse_si 'Phonetic Properties' items for Japanese excel files,
the Phonetic items(KATAKANA) represents pronunciation hints of String(KANJI).

<si>
 <t>漢字(japanese KANJI)</t>
 <rPh>
  <t>フリガナ(this is KATAKANA for pronounciation:漢字)</t>
 </rPh>
</si>

It expected get '漢字' . but got '漢字フリガナ'.
so replace these string, because this can be caused by only <rPh>.

Hi. using #parse_si 'Phonetic Properties' items for Japanese excel files, the Phonetic items(KATAKANA) represents pronunciation hints of String(KANJI). ``` xml <si> <t>漢字(japanese KANJI)</t> <rPh> <t>フリガナ(this is KATAKANA for pronounciation:漢字)</t> </rPh> </si> ``` It expected get '漢字' . but got '漢字フリガナ'. so replace these string, because this can be caused by only `<rPh>`.

SheetJSDev commented

2014-10-30 06:09:08 +00:00

(Migrated from github.com)

@tgfjt do you have a sample file that shows this? I'd like to set up some tests as well

coveralls commented

2014-10-30 06:18:43 +00:00

(Migrated from github.com)

Coverage remained the same when pulling cb7503de12 on tgfjt:patch-1 into f9097d403b on SheetJS:master.

[![Coverage Status](https://coveralls.io/builds/1403252/badge)](https://coveralls.io/builds/1403252) Coverage remained the same when pulling **cb7503de12923c0a60b4ca6ba603db84c88a6f56 on tgfjt:patch-1** into **f9097d403b44a0165ecb45dd9a798492b462b339 on SheetJS:master**.

tgfjt commented

2014-10-30 06:55:55 +00:00

(Migrated from github.com)

@SheetJSDev
done.
https://github.com/tgfjt-boxbox/xlsx-parse-sample

It seems to be caused by colored KANJI😓

@SheetJSDev done. https://github.com/tgfjt-boxbox/xlsx-parse-sample It seems to be caused by colored KANJI:sweat:

tgfjt commented

2015-02-05 08:59:24 +00:00

(Migrated from github.com)

@SheetJSDev
I'd like to you inform us about current status...

@SheetJSDev I'd like to you inform us about current status...

tgfjt commented