fix: zero number format bug #1703

Closed
suntopo wants to merge 0 commits from master into master
suntopo commented 2019-12-12 09:53:35 +00:00 (Migrated from github.com)

test demo in nodejs

var xlsx = require('node-xlsx');
var fs = require('fs');

const data = [[1, {t: 'n', f: 2, z: 2}, {t: 'n', f: 0, z: 2}]]

var buffer = xlsx.build([{name: "mySheetName", data: data}]); // Returns a buffer
fs.writeFileSync('test.xlsx', buffer)

before change

2019-12-12 17-52-03屏幕截图

after change

2019-12-12 17-53-03屏幕截图

## test demo in nodejs ``` var xlsx = require('node-xlsx'); var fs = require('fs'); const data = [[1, {t: 'n', f: 2, z: 2}, {t: 'n', f: 0, z: 2}]] var buffer = xlsx.build([{name: "mySheetName", data: data}]); // Returns a buffer fs.writeFileSync('test.xlsx', buffer) ``` ## before change ![2019-12-12 17-52-03屏幕截图](https://user-images.githubusercontent.com/5196122/70701990-44d56100-1d08-11ea-843c-781ffe5fd85c.png) ## after change ![2019-12-12 17-53-03屏幕截图](https://user-images.githubusercontent.com/5196122/70701989-443cca80-1d08-11ea-9313-6eb7cda75492.png)
SheetJSDev commented 2020-09-09 00:15:16 +00:00 (Migrated from github.com)

The issue here is that f should be a string, not a number:

const data = [[1, {t: 'n', f: "2", z: 2}, {t: 'n', f: "0", z: 2}]]

So it's preferable to check if it is a string

The issue here is that `f` should be a string, not a number: ```js const data = [[1, {t: 'n', f: "2", z: 2}, {t: 'n', f: "0", z: 2}]] ``` So it's preferable to check if it is a string

Pull request closed

Sign in to join this conversation.
No description provided.