sheetjs/sheetjs
37
Fork 37
Code Issues 193 Pull Requests 12 Wiki Activity

Update CONTRIBUTING doc for opening pull requests #2003

Merged
srijonsaha merged 1 commits from contributing-doc into master 2020-06-12 21:37:08 +00:00
Conversation 0 Commits 1 Files Changed 1 +7
srijonsaha commented 2020-06-12 20:43:40 +00:00 (Migrated from github.com)
Copy Link

Add info about [ci skip] to avoid travis ci and commits should also be squashed.

Add info about `[ci skip]` to avoid travis ci and commits should also be squashed.
garrettluu (Migrated from github.com) reviewed 2020-06-12 20:50:46 +00:00
garrettluu (Migrated from github.com) left a comment
Copy Link

Looks good, I would just add a note about using git rebase to squash commits.

Looks good, I would just add a note about using `git rebase` to squash commits.
garrettluu (Migrated from github.com) approved these changes 2020-06-12 21:30:34 +00:00
garrettluu (Migrated from github.com) left a comment
Copy Link

Looks good to me!

Looks good to me!
Sign in to join this conversation.
Reviewers
No reviewers
garrettluu
Labels
Clear labels   
DBF

   
Dates

   
Defined Names

   
Features

   
Formula

   
HTML

   
Images

   
Infrastructure

   
Integration

   
International

   
ODS

   
Operations

   
Performance

   
PivotTables

   
Pro

   
Protection

   
Read Bug

   
SSF

   
SYLK

   
Style

   
Write Bug

   
good first issue
No Label
DBF
Dates
Defined Names
Features
Formula
HTML
Images
Infrastructure
Integration
International
ODS
Operations
Performance
PivotTables
Pro
Protection
Read Bug
SSF
SYLK
Style
Write Bug
good first issue
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sheetjs/sheetjs#2003
No description provided.
Delete Branch "contributing-doc"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?