Update CONTRIBUTING doc for opening pull requests #2003

Merged
srijonsaha merged 1 commits from contributing-doc into master 3 years ago
srijonsaha commented 3 years ago (Migrated from github.com)
Owner

Add info about [ci skip] to avoid travis ci and commits should also be squashed.

Add info about `[ci skip]` to avoid travis ci and commits should also be squashed.
garrettluu (Migrated from github.com) reviewed 3 years ago
garrettluu (Migrated from github.com) left a comment
Owner

Looks good, I would just add a note about using git rebase to squash commits.

Looks good, I would just add a note about using `git rebase` to squash commits.
garrettluu (Migrated from github.com) approved these changes 3 years ago
garrettluu (Migrated from github.com) left a comment
Owner

Looks good to me!

Looks good to me!

Reviewers

The pull request has been merged as cdfe678571.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: sheetjs/sheetjs#2003
Loading…
There is no content yet.