decode_range returns same reference for s and e when input range is a single cell #2026
No reviewers
Labels
No Label
DBF
Dates
Defined Names
Features
Formula
HTML
Images
Infrastructure
Integration
International
ODS
Operations
Performance
PivotTables
Pro
Protection
Read Bug
SSF
SYLK
Style
Write Bug
good first issue
No Milestone
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: sheetjs/sheetjs#2026
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "kkerber/fix-same-ref-single-cell-range"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
When calling
decode_range
with a single cell, ie:xlsx.utils.decode_range('A1')
, you end up with an object wheres
ande
are the same reference. Therefore, if you modifye.c
ore.r
, it will appear as ifs.c
ors.r
has also been affected and vice versa. This code change ensuress
ande
are independent references so that they don't side-effect each other.Simple test:
Best place is in the
API
test blockLooks like tests failed to run due to a resource that has moved off bitbucket - https://bitbucket.org/openpyxl/openpyxl/src/master/
As long as the new test passes, it's safe to merge. We have to update the test files repo to make it work, and at this stage it might be better to mirror the repo or just add their specimens