xlsx-cli refactor #2029

2020-06-27T01:17:51Z

garrettluu commented

2020-06-27 01:17:51 +00:00

(Migrated from github.com)

Closes #1922

Refactored the CLI into packages/xlsx-cli and published the NPM package here.
With this refactor, we have completely commander and exit-on-epipe as dependencies in the main library and the submodules.

For convenience, here are the PRs for the CLI refactors of the submodules in one place:

To run the cli, install it with npm i -g xlsx-cli, then run npx xlsx-cli.

Closes #1922 Refactored the CLI into `packages/xlsx-cli` and published the NPM package [here](http://npmjs.com/package/xlsx-cli). With this refactor, we have completely `commander` and `exit-on-epipe` as dependencies in the main library and the submodules. For convenience, here are the PRs for the CLI refactors of the submodules in one place: - [alder32](https://github.com/SheetJS/js-adler32/pull/4) - [ssf](https://github.com/SheetJS/ssf/pull/51) - [crc32](https://github.com/SheetJS/js-crc32/pull/15) - [cfb](https://github.com/SheetJS/js-cfb/pull/10) To run the cli, install it with `npm i -g xlsx-cli`, then run `npx xlsx-cli`.

SheetJSDev (Migrated from github.com) reviewed 2020-06-27 01:17:51 +00:00

srijonsaha (Migrated from github.com) approved these changes 2020-06-29 18:51:25 +00:00

srijonsaha (Migrated from github.com) left a comment

There's some conflicts that need to be resolved. Otherwise looks good to me.

stof commented

2020-07-16 10:07:47 +00:00

(Migrated from github.com)

The xlsx-cli package.json should have the repository config, so that npmjs.com can link to the source repository.

The xlsx-cli package.json should have the `repository` config, so that npmjs.com can link to the source repository.

stof commented

2020-07-16 10:09:37 +00:00

(Migrated from github.com)