sheetjs
/
sheetjs
25
Fork 25
Code Issues 177 Pull Requests 12 Wiki Activity

Issue#2139 | fix for json_to_sheet - mutates header array #2146

Closed
tomRzeznik wants to merge 0 commits from master into master
pull from: master
merge into: sheetjs:master
Conversation 3 Commits - Files Changed -
tomRzeznik commented 2020-10-14 12:09:31 +00:00 (Migrated from github.com)
Copy Link
No description provided.
tomRzeznik commented 2020-10-14 12:12:53 +00:00 (Migrated from github.com)
Copy Link

Fix for header array mutation #2139

Fix for header array mutation #2139
himanshusaini111 commented 2021-01-05 17:15:24 +00:00 (Migrated from github.com)
Copy Link

No Fix is needed the behaviour was intentional, as mentioned in the issue discussion.

No Fix is needed the behaviour was intentional, as mentioned in the issue discussion.
SheetJSDev commented 2021-09-09 17:49:39 +00:00 (Migrated from github.com)
Copy Link

The behavior is intentional. https://github.com/SheetJS/sheetjs/issues/2139#issuecomment-706763053 explains it further. The "fix" is to clarify the documentation. As the discussion revealed, many libraries behave differently and a line in the documentation would help set expectations.

The behavior is intentional. https://github.com/SheetJS/sheetjs/issues/2139#issuecomment-706763053 explains it further. The "fix" is to clarify the documentation. As the discussion revealed, many libraries behave differently and a line in the documentation would help set expectations.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
DBF

   
Dates

   
Defined Names

   
Features

   
Formula

   
HTML

   
Images

   
Infrastructure

   
Integration

   
International

   
ODS

   
Operations

   
Performance

   
PivotTables

   
Pro

   
Protection

   
Read Bug

   
SSF

   
SYLK

   
Style

   
Write Bug

   
good first issue
No Label
DBF
Dates
Defined Names
Features
Formula
HTML
Images
Infrastructure
Integration
International
ODS
Operations
Performance
PivotTables
Pro
Protection
Read Bug
SSF
SYLK
Style
Write Bug
good first issue
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sheetjs/sheetjs#2146
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?