sheetjs
/
sheetjs
25
Fork 25
Code Issues 177 Pull Requests 12 Wiki Activity

fix issue #2460 #2461

Closed
giuliohome wants to merge 0 commits from master into master
pull from: master
merge into: sheetjs:master
Conversation 5 Commits - Files Changed -
giuliohome commented 2021-11-24 12:36:36 +00:00 (Migrated from github.com)
Copy Link

See the issue for more details

See the [issue](https://github.com/SheetJS/sheetjs/issues/2460) for more details
giuliohome commented 2021-11-24 14:50:48 +00:00 (Migrated from github.com)
Copy Link

Let me try to see if the issue can be fixed with option defval: null in sheet_to_json and without this PR...
A moment, I'll be back, thanks

Let me try to see if the issue can be fixed with option `defval: null` in sheet_to_json and without this PR... A moment, I'll be back, thanks
giuliohome commented 2021-11-24 15:03:47 +00:00 (Migrated from github.com)
Copy Link

Issue and PR closed as per my comment

Issue and **PR closed** as per my [comment](https://github.com/SheetJS/sheetjs/issues/2460#issuecomment-977960516)
ghost commented 2021-11-24 15:42:54 +00:00 (Migrated from github.com)
Copy Link

I am broke, no money, yet 3.6 million offer in Google Calendar. What in the
hell, do you want from me. WHAT? WHAT!
On Wed, Nov 24, 2021 at 09:04 giuliohome @.***> wrote:

Closed #2461 https://github.com/SheetJS/sheetjs/pull/2461.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/SheetJS/sheetjs/pull/2461#event-5667553871, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AVQWQIH7X3R5I35FVPMPCKLUNT5ITANCNFSM5IV6YZ5Q
.

I am broke, no money, yet 3.6 million offer in Google Calendar. What in the hell, do you want from me. WHAT? WHAT! On Wed, Nov 24, 2021 at 09:04 giuliohome ***@***.***> wrote: > Closed #2461 <https://github.com/SheetJS/sheetjs/pull/2461>. > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <https://github.com/SheetJS/sheetjs/pull/2461#event-5667553871>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AVQWQIH7X3R5I35FVPMPCKLUNT5ITANCNFSM5IV6YZ5Q> > . >
giuliohome commented 2021-11-24 16:51:34 +00:00 (Migrated from github.com)
Copy Link

Reopened to introduce new option keeporder: true
I will squash the 2 commits into one

Reopened to introduce new option `keeporder: true` I will squash the 2 commits into one
giuliohome commented 2021-11-24 17:42:53 +00:00 (Migrated from github.com)
Copy Link

I'll redo the PR to avoid the rebase failure...

I'll redo [the PR](https://github.com/SheetJS/sheetjs/pull/2462) to avoid the rebase failure...

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
DBF

   
Dates

   
Defined Names

   
Features

   
Formula

   
HTML

   
Images

   
Infrastructure

   
Integration

   
International

   
ODS

   
Operations

   
Performance

   
PivotTables

   
Pro

   
Protection

   
Read Bug

   
SSF

   
SYLK

   
Style

   
Write Bug

   
good first issue
No Label
DBF
Dates
Defined Names
Features
Formula
HTML
Images
Infrastructure
Integration
International
ODS
Operations
Performance
PivotTables
Pro
Protection
Read Bug
SSF
SYLK
Style
Write Bug
good first issue
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sheetjs/sheetjs#2461
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?