Read + write style information to .xlsx #263
A collective series of changes that allows style information to be read from and written to xlsx files. This should not affect .xls or .xlsb files.
Submitting a pull request so that the option to merge the changes exists. Am open to additional steps to harmonize this with the rest of the lib if required.
@protobi check your email.
We're gonna squash, so don't worry about the commit log for the moment. Taking a quick scan at the changed files (https://github.com/SheetJS/js-xlsx/pull/263/files?diff=unified click on "changed files"):
- I just noticed you added some files .DS_Store and .idea/scopes/scope_settings which should be removed (probably should add .DS_Store and .idea/ to the .gitignore
- Should the lab directory also be ignored?
- Can you move the new test files (test-*.js as well as supporting files like out.txt) to the tests subdirectory? We can blow away the old jasmine tests
- I'm not sure whether the example files should be put in the misc folder or in a separate samples directory. Thoughts?
Files now removed from the repo, these had earlier been inadvertently added.
This is awesome!
@protobi are you able to mention in the docs that you need to put cell styles inside the
s property before being encoded? I was having hard time figuring out why my styles weren't showing up.
@rclai Thanks for beta testing the docs and providing that feedback. Will edit this docs later this week.
👍 this was a great help to find thanks @protobi . Modifying without changing styling was a must have for my project.
any chance this will be merged?
how exciting, renewed activity means this has finally has a chance of being pulled in i hope
We're slowly picking changes. The first commit, credited to @protobi, fills out some holes in the xml style parsing. It won't show up in the github UI as a merge but it will credit you as a contributor.
Instead of hardcoding the specific property overrides, the writer now takes a
Props key in the options object and uses those instead of the workbook properties. It's explained in the README, but it boils down to the following changes:
The mapping from the XLSX name to the CSF name is in the
CORE_PROPS variable in
the theme override is now passed with the
themeXml is ambiguous since multiple formats use xml-based themes, so calling it
themeXLSX makes it clear we are talking about pass-through XLSX-style themes.
@SheetJSDev ,when this PR will get merged ?
I am waiting for its new release with the support of style.
Need this too! Hopefully it will be merged soon 🙏
@SheetJSDev, can you please advise as to when this will get merged? I need to style & format the cells.
Hi @SheetJSDev, when this PR will be merged with master branch ?
BUMP! This is quite an important feature for us, is it possible to merge it soon @protobi @SheetJSDev ? Do you need any help in order to speed up the process? This PR has been open for far too long.
Important for us too
Any luck on merging everything?
I don't have any idea why I am in reviewer list, @SheetJSDev can you please check this.
@nakshay here is the answer 🙂
@nakshay here is the answer 🙂
Yeh embarrassing , happened by mistake, and not able to find way to undo it .
Any updates on this PR?
Annual bump... 6 years later, still would be useful.
This is vital to me to be able to use the library.
CheckoutFrom your project repository, check out a new branch and test the changes.
MergeMerge the changes and update on Gitea.
No due date set.
No dependencies set.
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?